Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Hi team,
We're looking to make a few changes that would allow folks to populate the
sql_query_mutator
with more useful params. We're open to discussion on the best practices to do so.These are the three items we're looking to change:
slice_id
toquery_obj
: As addition context forquery_obj
. Having slice_id is versatile and can open doors for powerful integrations/automations. We originally wanted to add in the whole slice object for more options, but some integration tests failed since the object cannot be converted to a dictionary. Happy to discuss the best way to do this going forward.chart_id
anddataset_id
as default parameters for mutate_query_from_configExample Usecase, Automated Data Access Requests via Satori:
Context: We use Satori for our data access management.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
Changed query_obj tests to account for additional parameters:
ADDITIONAL INFORMATION