Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

passing mergerfs parameters as env var or configuration file #74

Merged
merged 5 commits into from
Jul 20, 2024

Conversation

hvalev
Copy link
Owner

@hvalev hvalev commented Jul 15, 2024

  • updated mergerfs to use parameters from a configuration file
  • allowing parameters set as an environment variable to override configuration file
  • fixed bug for not releasing fs handle when docker sends SIGTERM signal on container stop fixing umount before mount ? #51

@hvalev hvalev changed the title mergerfs default params passing mergerfs parameters as env var or configuration file Jul 15, 2024
entrypoint.sh Outdated
echo "$MERGERFS_PARAMS" > "$PARAMETERS_FILE"
fi

# Merge parameters from the file into a single line without comments or empty lines

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a bit convoluted given you can simply pass -o config=$PARAMETERS_FILE if you rework the above mechanism a bit.
But that works I guess

@hvalev hvalev merged commit 409f072 into main Jul 20, 2024
1 check passed
@hvalev hvalev mentioned this pull request Jul 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants