Skip to content

feat: add support for PHP 8.3 #44

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 29, 2023
Merged

feat: add support for PHP 8.3 #44

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9d166ac
feat: add support for PHP 8.3
hussainweb Nov 29, 2023
bbab6a5
Add prepared script
github-actions[bot] Nov 29, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,26 +6,27 @@ This action runs checks from [DrupalQA](https://github.com/hussainweb/drupalqa)

### `php-version`

The PHP version to use (corresponds to the Docker image). Allowed options are and their corresponding Docker images are as follows. Default: `8.1`.
The PHP version to use (corresponds to the Docker image). Allowed options and their corresponding Docker images are as follows. Default: `8.2`.

| php-version | Docker image |
| ----------- | ------------ |
| 7.3 | hussainweb/drupalqa:php7.3 (_not supported_) |
| 7.4 | hussainweb/drupalqa:php7.4 (_not supported_) |
| 8.0 | hussainweb/drupalqa:php8.0 |
| 8.0 | hussainweb/drupalqa:php8.0 (_not supported_) |
| 8.1 | hussainweb/drupalqa:php8.1 |
| 8.2 | hussainweb/drupalqa:php8.1 |
| 8.2 | hussainweb/drupalqa:php8.2 |
| 8.3 | hussainweb/drupalqa:php8.3 |
| latest | hussainweb/drupalqa:latest |

Note: The actual Docker image used also depends on the `registry` option. If that option is set to `'ghcr'` (default value), then the Docker image is prefixed with `ghcr.io/`. For example, `ghcr.io/hussainweb/drupalqa:php8.2`.

### `web-root`

The web root (document root) to consider for default values for some of the checks. Default: `web`.
The web root (document root) for default values for some of the checks. Default: `web`.

### `checks`

An YAML string describing the checks to run. The default structure is as below.
A YAML string describing the checks to run. The default structure is as below.

```yaml
checks: |
Expand Down
2 changes: 1 addition & 1 deletion dist/index.js
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion dist/index.js.map
View file
Open in desktop

Large diffs are not rendered by default.

4 changes: 3 additions & 1 deletion src/main.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,9 @@ const availableChecks: {

async function run(): Promise<void> {
const phpVersion = core.getInput('php-version')
if (!['7.3', '7.4', '8.0', '8.1', '8.2', 'latest'].includes(phpVersion)) {
if (
!['7.3', '7.4', '8.0', '8.1', '8.2', '8.3', 'latest'].includes(phpVersion)
) {
throw new Error('Invalid PHP version.')
}

Expand Down