Skip to content

Conversation

@hussainweb
Copy link
Owner

@hussainweb hussainweb commented Oct 14, 2025

This commit updates the default PHP version used by the action to 8.4.
It also updates the README to reflect this change and adds badges for new workflows.

Summary by CodeRabbit

  • Documentation

    • Added badges to the README.
    • Updated PHP references to default to 8.4.
    • Clarified support matrix, marking PHP 8.1 as not supported.
    • Updated example usage to PHP 8.4.
  • Chores

    • Changed the GitHub Action’s default php-version input to 8.4, maintaining existing behavior for users relying on defaults.

This commit updates the default PHP version used by the action to 8.4.
It also updates the README to reflect this change and adds badges for new workflows.
@coderabbitai
Copy link

coderabbitai bot commented Oct 14, 2025

Walkthrough

Updated references to PHP 8.4: README badges and version mentions revised, PHP 8.1 marked not supported, and example usage updated. In action.yml, the default input php-version changed from 8.2 to 8.4. No other behavior or signatures changed.

Changes

Cohort / File(s) Summary of Changes
Documentation updates
README.md
Added badges; updated default PHP version references from 8.2 to 8.4; marked PHP 8.1 as not supported; adjusted example usage to 8.4.
Action input default
action.yml
Changed inputs.php-version.default from '8.2' to '8.4'; no other inputs/outputs modified.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

A whisk of versions, hop to eight-point-four,
Badges gleam brighter than they did before.
I nudge the defaults, thump-thump—no fuss,
Docs in a row, neat as a rabbit’s truss.
Carrot-colored semvers line the burrow door.

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check ✅ Passed The pull request title clearly and succinctly summarizes the primary change—updating the default PHP version to 8.4—and follows a concise conventional commit style. It accurately reflects the modifications made to action.yml and the README without including extraneous details.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch update-defaults

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
README.md (1)

32-34: Align the GHCR example with the new default

Line 34 still references the php8.2 tag even though the documented default is now 8.4. Please update the example tag to php8.4 (or make the example version‑agnostic) so the docs stay self-consistent.

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 446a2bd and 14b47f6.

📒 Files selected for processing (2)
  • README.md (3 hunks)
  • action.yml (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: Lint Codebase
🔇 Additional comments (1)
action.yml (1)

7-7: Confirm availability of the php8.4 image

Before merging, please confirm that hussainweb/drupalqa:php8.4 (and the corresponding GHCR image) is published and available; otherwise the new default will fail pulls for anyone who omits php-version.

@hussainweb hussainweb merged commit 170be6c into main Oct 14, 2025
23 checks passed
@hussainweb hussainweb deleted the update-defaults branch October 14, 2025 00:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants