Added elevation data on simulator side #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed GPS sensor data to contain information about elevation data. However the elevation might not be in right units.
imisaacwu
requested changes
Nov 19, 2024
| transform.position.x + _noise * Utilities.GaussianRandom()}, | ||
| new double[] {initLat, initLon}); | ||
| transform.position.x + _noise * Utilities.GaussianRandom(), | ||
| transform.position.y + _noise * Utilities.GaussianRandom()}, |
There was a problem hiding this comment.
If we are reporting the altitude in meters anyway, I don't think we need to pass it into this metersToGPS function
| new double[] {initLat, initLon}); | ||
| transform.position.x + _noise * Utilities.GaussianRandom(), | ||
| transform.position.y + _noise * Utilities.GaussianRandom()}, | ||
| new double[] {initLat, initLon, initAlt}); | ||
|
|
There was a problem hiding this comment.
Can probably just insert something like double altitude = transform.position.y + _noise * Utilities.GaussianRandom(); here and use it in the report below
|
|
||
| JObject positionReport = new JObject() | ||
| { | ||
| ["type"] = "simGpsPositionReport", | ||
| ["latitude"] = GPS[0], | ||
| ["longitude"] = GPS[1] | ||
| ["longitude"] = GPS[1], | ||
| ["altitude"] = GPS[2] | ||
| }; | ||
| _socket.Send(positionReport); |
There was a problem hiding this comment.
Make sure to update the READMEs with the updated report packets please 🙏
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed GPS sensor data to contain information about elevation data and for that data to be sent over in the positionReport Json.