Update English strings in the app and the README (read description) #569
Conversation
| This project contains the complete code of the system Easter eggs, which aims to organize and be | ||
| compatible with all system easter eggs, so as to ensure that most devices can experience different | ||
| versions of Easter eggs without making too many modifications to the easter egg's code. | ||
| This project contains the complete code for all Android Easter eggs, aiming to organize and ensure compatibility with all Android Easter eggs. The goal is to enable most devices to experience different versions of the Easter eggs with minimal modifications to the Easter egg's code. Newer versions use newer system features, while older versions are limited to using only certain features. |
There was a problem hiding this comment.
"Newer versions use newer system features, while older versions are limited to using only certain features.
Comment"
This is incorrect. It's not that only the new version of the Easter egg uses the new system features; it's just that some are in use. https://github.com/hushenghao/AndroidEasterEggs/wiki/Android-versions
There was a problem hiding this comment.
I've changed it. How about the new one?
There was a problem hiding this comment.
Or delete this sentence 'Newer versions use newer system features, while older versions are limited to using only certain features.'
There was a problem hiding this comment.
Or delete this sentence '
Newer versions use newer system features, while older versions are limited to using only certain features.'
I think I changed that string but maybe it doesn't show up there. Can you check the latest commit?
There was a problem hiding this comment.
README.md
string.xml: label_project_desc
There are two places in your modifications that are different.
| <string name="summary_system_default">Default</string> | ||
| <string name="summary_theme_dark_mode">Dark</string> | ||
| <string name="summary_theme_light_mode">Light</string> | ||
| <string name="summary_theme_amoled_mode">AMOLED</string> | ||
| <string name="summary_theme_amoled_mode">Black</string> |
There was a problem hiding this comment.
Black and Dark , It's easy to confuse
There was a problem hiding this comment.
I disagree. I think AMOLED is even more confusing since you do not need to have that screen technology in order to use the theme and the screen technology isn't related to the theme colors. I think people will understand the difference.
| <string name="label_about">About</string> | ||
| <string name="label_contribute">Contribute</string> | ||
| <string name="animator_disabled_alert_message">Due to the system animation being disabled, some features may not work properly. Please go to \"Developer Options\" and enable the \"Animator duration scale\" option to activate the animation.</string> | ||
| <string name="action_goto_settings">Go to Settings</string> | ||
| <string name="animator_disabled_alert_message">Due to the system animations being disabled, some features may not work properly. Please go to the accessibility settings and enable animations to activate the animations</string> |
There was a problem hiding this comment.
"Developer Options" , "Animator duration scale"
These are the contents of the options in the Settings of the system developers and do not need to be modified.
There was a problem hiding this comment.
"Developer Options" , "Animator duration scale" These are the contents of the options in the Settings of the system developers and do not need to be modified.
The user may have not enabled developer options. Not sure if it is possible to navigate there without activating it. I think there should be a toggle to disable animations in accessibility for probably almost all modern Android devices.
There was a problem hiding this comment.
If the user does not activate the developer option, the "Animator duration scale" option will not be disabled, so you don't need to worry
There was a problem hiding this comment.
If the user does not activate the developer option, the "Animator duration scale" option will not be disabled, so you don't need to worry
I think there should be a toggle to disable animations in accessibility for probably almost all modern Android devices.
I think that toggle is functionally the same as setting all the animation scales to 0.
There was a problem hiding this comment.
If the animation duration scale is set to 0, it will cause the animation to fail to play properly. The purpose of this dialog box is to guide the user to enable an animation duration scale (which cannot be 0).
There was a problem hiding this comment.
If the animation duration scale is set to 0, it will cause the animation to fail to play properly. The purpose of this dialog box is to guide the user to enable an animation duration scale (which cannot be 0).
I think disabling the toggle I mentioned should set the animation scale to a non-zero value (probably the same as what it was when the toggle wasn't enabled).
| <string name="label_component_manager">Components manager</string> | ||
| <string name="pref_more_settings">More settings</string> | ||
| <string name="pref_retain_recent_egg_tasks">Retain Easter egg tasks</string> | ||
| <string name="pref_summary_retain_recent_egg_tasks">Retain Easter egg tasks on Recents screen. Up to 5 can be retained. Not available for the Activity Embedded Mode</string> |
There was a problem hiding this comment.
"Activity Embedded Mode" It is not applicable to all devices, so parentheses have been added to inform users
There was a problem hiding this comment.
What devices is it applicable to?
Also: https://m3.material.io/foundations/content-design/style-guide/grammar-and-punctuation#ba2fc0de-152d-4562-b43d-abd6a9378a94
There was a problem hiding this comment.
Activity embedding is supported on most large screen devices running Android 12L (API level 32) and higher.
| <string name="animator_disabled_alert_message">Due to the system animation being disabled, some features may not work properly. Please go to \"Developer Options\" and enable the \"Animator duration scale\" option to activate the animation.</string> | ||
| <string name="action_goto_settings">Go to Settings</string> | ||
| <string name="animator_disabled_alert_message">Due to the system animations being disabled, some features may not work properly. Please go to the accessibility settings and enable animations to activate the animations</string> | ||
| <string name="action_goto_settings">Open</string> |
There was a problem hiding this comment.
This is a guide to setting developer options, I'm not sure if it's necessary to modify it
There was a problem hiding this comment.
The user may have not enabled developer options. Not sure if it is possible to navigate there without activating it. I think there should be a toggle to disable animations in accessibility for probably almost all modern Android devices.
The changes include instructing the user to enable animations through accessibility settings instead of developer options. That functionality should be changed. That string for other languages should be retranslated to change this. Maybe remove that string for other languages and let the translators know they should retranslate that string.
The repository description from the fork should also be a part of this pull request.