Don't copy the log on uninstall #57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… dir on uninstall
deborahjones-huntress
approved these changes
Sep 27, 2023
s-m-martin
reviewed
Sep 27, 2023
s-m-martin
approved these changes
Sep 27, 2023
There was a problem hiding this comment.
@rob-no please make sure we have one of our awesome SDETs try beating up this script before we merge it
rob-no
requested review from
cameron-huntress
and removed request for
Alan-Huntress
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're currently trying to copy the debug log to the Huntress folder on uninstall. Stop doing that!
Also added a force kill on the process exe's after we stop the service to make sure they exit before we try to run the uninstallers.