Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/wild-dogs-obey.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"bits-ui": patch
---

fix(NavigationMenu): delay hover close; add leave-delay regression test
Original file line number Diff line number Diff line change
Expand Up @@ -154,7 +154,7 @@ export class NavigationMenuRootState {
const isOpen = this.opts?.value?.current !== "";
if (isOpen || this.isDelaySkipped.current) {
// 150 for user to switch trigger or move into content view
return 100;
return 150;
} else {
return this.opts.delayDuration.current;
}
Expand Down
4 changes: 3 additions & 1 deletion tests/src/tests/navigation-menu/navigation-menu-test.svelte
Original file line number Diff line number Diff line change
Expand Up @@ -19,13 +19,15 @@
subGroupItemProps,
subGroupItem1Props,
subGroupItem2Props,
delayDuration = 0,
skipDelayDuration = 0,
...restProps
}: NavigationMenuTestProps = $props();
</script>

<main>
<button data-testid="previous-button" tabindex={0}>previous button</button>
<NavigationMenu.Root {...restProps} data-testid="root" delayDuration={0} skipDelayDuration={0}>
<NavigationMenu.Root {...restProps} data-testid="root" {delayDuration} {skipDelayDuration}>
<NavigationMenu.List data-testid="list">
<NavigationMenu.Item value="group" data-testid="group-item" {...groupItemProps}>
<NavigationMenu.Trigger data-testid="group-item-trigger">
Expand Down
17 changes: 17 additions & 0 deletions tests/src/tests/navigation-menu/navigation-menu.browser.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ import { expectExists, expectNotExists } from "../browser-utils";
import { page, userEvent } from "@vitest/browser/context";

const kbd = getTestKbd();
const sleep = (ms: number) => new Promise((resolve) => setTimeout(resolve, ms));

/**
* Helper function to reduce boilerplate in tests
Expand All @@ -16,6 +17,22 @@ function setup(props: NavigationMenuTestProps = {}) {
return { ...returned };
}

it("should keep content open briefly after leaving a trigger", async () => {
setup({ delayDuration: 0, skipDelayDuration: 0 });
const trigger = page.getByTestId("group-item-trigger");
const outside = page.getByTestId("previous-button");

await trigger.hover();
await expectExists(page.getByTestId("viewport"));

await outside.hover();
await sleep(125);
await expectExists(page.getByTestId("viewport"));

await sleep(80);
await expectNotExists(page.getByTestId("viewport"));
});

it("should open viewport when hovering trigger", async () => {
setup();
const trigger = page.getByTestId("group-item-trigger");
Expand Down