Skip to content

feat(phone-app): fix Wear Engine package visibility and setup Jetpack Compose foundation (#40, #41) - #56

Closed
hungify wants to merge 4 commits into
mainfrom
feature/wear-engine-auth-and-compose-setup
Closed

hungify wants to merge 4 commits into
mainfrom
feature/wear-engine-auth-and-compose-setup

Conversation

@hungify

@hungify hungify commented Aug 26, 2026

Copy link
Copy Markdown
Owner

Summary

This PR bundles two foundational enhancements for the phone-app module:

  1. Fix Wear Engine Package Visibility & Authorization Prompt (Resolves fix(phone-app): Huawei Wear Engine package visibility queries and auth permission prompt #40):

    • Added <queries> block in AndroidManifest.xml for com.huawei.health and intent action com.huawei.health.action.WEAR_ENGINE_SERVICE to comply with Android 11+ (API 30+) package visibility requirements.
    • Added requestPermission() to WearEngineService / HuaweiWearEngineService wrapping AuthClient.requestPermission(AuthCallback, Permission.DEVICE_MANAGER) via suspendCancellableCoroutine.
    • Updated MainActivity and MainViewModel to trigger the permission request dialog when unauthorized and user taps "Connect Watch / Retry".
    • Added comprehensive unit tests in HuaweiWearEngineServiceTest and MainViewModelTest.
  2. Jetpack Compose BOM & Material 3 Theme Foundation (Resolves feat(phone-app): setup Jetpack Compose BOM, Kotlin Compose compiler, and Material 3 theme #41):

    • Configured official Kotlin Compose compiler plugin (org.jetbrains.kotlin.plugin.compose) matching Kotlin 2.0+.
    • Added Compose BOM (2024.10.01), Material 3 (material3), activity-compose, lifecycle-runtime-compose, and Material Icons Extended.
    • Enabled buildFeatures { compose = true }.
    • Implemented Material 3 theme foundation (Color.kt, Type.kt, Theme.kt) with Dynamic Color support on Android 12+ (API 31+) and dark/light system theme switching.
    • Added unit test ThemeTest.kt.

Verification

  • make test: All JVM unit tests passed across Phone App, Watch App, and Cloudflare Worker.
  • make lint: Android Lint and ESLint passed with 0 errors.
  • make pre-commit: Pre-commit secret safeguards passed cleanly.

Related Issues

@coderabbitai

coderabbitai Bot commented Aug 26, 2026

Copy link
Copy Markdown

Warning

Review limit reached

Next included review available in 53 minutes.

View limit details

Limit details: You’ve used the included review currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: edb088d8-7c3d-452c-925c-09696bcf2473

📥 Commits

Reviewing files that changed from the base of the PR and between 6f1a8cd and ee795c3.

📒 Files selected for processing (15)
  • phone-app/.editorconfig
  • phone-app/app/build.gradle.kts
  • phone-app/app/src/main/AndroidManifest.xml
  • phone-app/app/src/main/java/com/watchnavigator/MainActivity.kt
  • phone-app/app/src/main/java/com/watchnavigator/data/WearEngineService.kt
  • phone-app/app/src/main/java/com/watchnavigator/ui/MainViewModel.kt
  • phone-app/app/src/main/java/com/watchnavigator/ui/theme/Color.kt
  • phone-app/app/src/main/java/com/watchnavigator/ui/theme/Theme.kt
  • phone-app/app/src/main/java/com/watchnavigator/ui/theme/Type.kt
  • phone-app/app/src/test/java/com/watchnavigator/data/HuaweiWearEngineServiceTest.kt
  • phone-app/app/src/test/java/com/watchnavigator/engine/NavigationSessionManagerTest.kt
  • phone-app/app/src/test/java/com/watchnavigator/ui/MainViewModelTest.kt
  • phone-app/app/src/test/java/com/watchnavigator/ui/theme/ThemeTest.kt
  • phone-app/build.gradle.kts
  • phone-app/gradle/libs.versions.toml

Warning

Your free Security trial is over. An organization admin can activate billing to continue.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@hungify

hungify commented Aug 26, 2026

Copy link
Copy Markdown
Owner Author

Superseded by dedicated single-issue PRs for #40 and #41.

@hungify hungify closed this Aug 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

1 participant