Repository navigation
Conversation
|
Warning Review limit reachedNext included review available in 57 minutes. View limit detailsLimit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
Warning Your free Security trial is over. An organization admin can activate billing to continue. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
hungify
force-pushed
the
feature/issue-42-settings-screen-compose
branch
from
August 26, 2026 00:13
3e49c57 to
412c13a
Compare
Owner
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Migrates the phone app's Settings screen from legacy XML views and ViewBinding to a declarative Jetpack Compose Material 3 UI with reactive state handling.
Key Changes
SettingsScreen.kt:Scaffold,TopAppBar, and back navigation.SingleChoiceSegmentedButtonRowfor selecting default travel mode (Motorbike / Driving vs Walking).OutlinedTextFieldinputs for driving and walking watch vibration threshold distances with real-time numeric validation and range hints (10–1000 m).SettingsViewModelviacollectAsStateWithLifecycle()and displays save/error feedback viaSnackbarHost.@Previewcomposables for both Light and Dark theme modes.SettingsActivity.kt: Converted fromAppCompatActivitywith XML ViewBinding toComponentActivityrenderingSettingsScreenwithinWatchNavigatorTheme.SettingsViewModelTest.kt: Added boundary validation and ViewModel factory unit tests.Verification
./gradlew testDebugUnitTest: All unit tests pass cleanly../gradlew spotlessCheck: Spotless ktlint formatting checks pass.make test: Cross-module unit tests (phone & watch) pass 100%.Closes #42