Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Jan 30, 2026

  • Add support for FETCH_PROXY environment variable in CLI (src/server.js)
    • Read FETCH_PROXY environment variable
    • When FETCH_PROXY is set, use it for both httpProxy and httpsProxy
    • Update validation logic to accept FETCH_PROXY as an alternative to http_proxy/https_proxy
  • Update README.md to document FETCH_PROXY
  • Manually test FETCH_PROXY behavior
  • Run all tests to ensure changes don't break existing functionality (30/30 tests pass)
  • Run linter and formatter (no issues)
  • Address code review feedback
    • Rename FETCH_PROXY_URI to FETCH_PROXY per maintainer request
    • Revert unrelated changes to javascript.instructions.md

Summary

Successfully implemented the FETCH_PROXY environment variable for the CLI and addressed all code review feedback. The variable supersedes both http_proxy and https_proxy when set, allowing users to configure a single proxy URI for both HTTP and HTTPS requests.

Original prompt

Add a new environment variable to the command line, FETCH_PROXY_URI. When specified, this supercedes both http_proxy and https_proxy, allowing users to configure the proxy just for the fetch request rather than the whole process. We don't need to change createApp, this is just a feature for the CLI.


💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Copilot AI and others added 2 commits January 30, 2026 22:03
Co-authored-by: nzakas <38546+nzakas@users.noreply.github.com>
Co-authored-by: nzakas <38546+nzakas@users.noreply.github.com>
Copilot AI changed the title [WIP] Add FETCH_PROXY_URI to command line for fetch requests Add FETCH_PROXY_URI environment variable for CLI Jan 30, 2026
Copilot AI requested a review from nzakas January 30, 2026 22:07
@nzakas
Copy link
Contributor

nzakas commented Jan 30, 2026

@copilot actually, let's call it FETCH_PROXY instead of FETCH_PROXY_URI

Co-authored-by: nzakas <38546+nzakas@users.noreply.github.com>
Copy link
Contributor Author

Copilot AI commented Jan 30, 2026

@copilot actually, let's call it FETCH_PROXY instead of FETCH_PROXY_URI

Renamed to FETCH_PROXY in commit 270a602. Updated both the code and documentation.

Copilot AI changed the title Add FETCH_PROXY_URI environment variable for CLI Add FETCH_PROXY environment variable for CLI Jan 30, 2026
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@copilot Revert changes in this file.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reverted changes to javascript.instructions.md in commit a6acb32. The file has been restored to its original state.

@nzakas nzakas marked this pull request as ready for review January 31, 2026 00:10
Co-authored-by: nzakas <38546+nzakas@users.noreply.github.com>
Copilot AI requested a review from nzakas January 31, 2026 00:12
@nzakas nzakas merged commit 406e4ec into main Jan 31, 2026
9 checks passed
@nzakas nzakas deleted the copilot/add-fetch-proxy-uri-variable branch January 31, 2026 00:13
@nzakas nzakas restored the copilot/add-fetch-proxy-uri-variable branch January 31, 2026 00:16
nzakas added a commit that referenced this pull request Jan 31, 2026
nzakas added a commit that referenced this pull request Jan 31, 2026
Revert "Add FETCH_PROXY environment variable for CLI (#13)"

This reverts commit 406e4ec.
@nzakas nzakas deleted the copilot/add-fetch-proxy-uri-variable branch January 31, 2026 00:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants