Skip to content

[evm-tracing-0] add evm-tracing test suite to e2e ts tests #1574

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 28, 2025

Conversation

dmitrylavrenov
Copy link
Contributor

@dmitrylavrenov dmitrylavrenov commented Jul 19, 2025

image

@dmitrylavrenov dmitrylavrenov changed the base branch from master to evm-debug-trace July 19, 2025 11:50
@dmitrylavrenov dmitrylavrenov mentioned this pull request Jul 19, 2025
6 tasks
@dmitrylavrenov
Copy link
Contributor Author

@MOZGIII

I would like to finalize the code we would like to have as a part of TDD for EVM tracing logic. At the current moment it's unclear to me what exactly should we have.

I started preparing a proper test to execute RPC request for debug_traceCall and discovered that current moonbeam implementation doesn't meet debug trace call specification. For example, tracerConfig doesn't contain enableReturnData at moonebeam version, but the spec tracerConfig does.

I was thinking in terms of TDD that we should take the specification and implement some simple tests at least that follow the spec. But it can be different from moonbeam implementation, like request call data type. So, I guess we should define request/response types and test data at least.

Currently I started with a374702.

@dmitrylavrenov
Copy link
Contributor Author

@MOZGIII

I would like to finalize the code we would like to have as a part of TDD for EVM tracing logic. At the current moment it's unclear to me what exactly should we have.

I started preparing a proper test to execute RPC request for debug_traceCall and discovered that current moonbeam implementation doesn't meet debug trace call specification. For example, tracerConfig doesn't contain enableReturnData at moonebeam version, but the spec tracerConfig does.

I was thinking in terms of TDD that we should take the specification and implement some simple tests at least that follow the spec. But it can be different from moonbeam implementation, like request call data type. So, I guess we should define request/response types and test data at least.

Currently I started with a374702.

Separated the PR, moved the tests itself logic to #1575

@dmitrylavrenov dmitrylavrenov marked this pull request as ready for review July 21, 2025 14:15
@dmitrylavrenov dmitrylavrenov changed the title [evm-tracing-0] add a corresponding e2e tests [evm-tracing-0] add evm-tracing test suite to e2e bash/ts tests Jul 21, 2025
@dmitrylavrenov
Copy link
Contributor Author

Will rebase after #1580

@dmitrylavrenov dmitrylavrenov changed the title [evm-tracing-0] add evm-tracing test suite to e2e bash/ts tests [evm-tracing-0] add evm-tracing test suite to e2e ts tests Jul 28, 2025
@dmitrylavrenov dmitrylavrenov requested a review from MOZGIII July 28, 2025 16:52
@dmitrylavrenov dmitrylavrenov merged commit ff3f91a into evm-debug-trace Jul 28, 2025
23 checks passed
@dmitrylavrenov dmitrylavrenov deleted the evm-debug-e2e-test branch July 28, 2025 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants