-
Notifications
You must be signed in to change notification settings - Fork 1
Release 0.8.36b1: Agents Support in SDK #59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
2057390
to
fcefc53
Compare
cb295f3
to
914091b
Compare
7ef38da
to
911db83
Compare
src/humanloop/evals/run.py
Outdated
|
||
|
||
def _safe_get_default_file_version(client: "BaseHumanloop", file_config: FileEvalConfig) -> EvaluatedFile: | ||
"""Get default version of a File from online workspace. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit (non-blocking): "remote" workspace?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ack
src/humanloop/evals/run.py
Outdated
subclient = _get_subclient(client=client, file_config=file_config) | ||
return subclient.get(id=file_id) | ||
else: | ||
raise HumanloopRuntimeError("You must provide a path or id in your `file` config.") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe "You must provide either a path or id in your file
config". Or something to indicate it's an XOR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ack
|
||
if type == "flow": | ||
if type_ == "flow": |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no agent here? Why can't you upsert? From what I can tell this upserts based on the version param in eval.run?
elif type == "evaluator": | ||
hl_file = client.evaluators.upsert(**file_dict) # type: ignore [arg-type, assignment] | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also is removing this a breaking change?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
more of some hanging code, we do not support evals.run on evaluators
src/humanloop/flows/client.py
Outdated
<<<<<<< HEAD | ||
"2024-07-08 21:40:35+00:00", | ||
), | ||
end_time=datetime.datetime.fromisoformat( | ||
"2024-07-08 21:40:39+00:00", | ||
======= | ||
"2024-07-08 19:40:35+00:00", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
merge conflicts?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed
def print_error(message: str) -> None: | ||
"""Print a formatted error message to stdout.""" | ||
sys.stdout.write(f"{RED}{message}{RESET}") | ||
|
||
|
||
def print_warning(message: str) -> None: | ||
"""Print a formatted warning message to stdout.""" | ||
sys.stdout.write(f"{YELLOW}{message}{RESET}\n") | ||
|
||
|
||
def print_info(message: str) -> None: | ||
"""Print a formatted info message to stdout.""" | ||
sys.stdout.write(f"{CYAN}{message}{RESET}\n") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
much nicer thank you for this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ack <3
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a few comments/possible fixes, but generally lgtm. Didn't look at all the autogenerated code, but the enum of events seems reasonable.
4ba6bb5
to
52736e3
Compare
52736e3
to
189c9d9
Compare
No description provided.