Skip to content

Release 0.8.36b1: Agents Support in SDK #59

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 30, 2025
Merged

Conversation

andreibratu
Copy link
Contributor

No description provided.

@andreibratu andreibratu marked this pull request as draft April 15, 2025 20:06
@andreibratu andreibratu force-pushed the add-agents-sdk branch 2 times, most recently from 2057390 to fcefc53 Compare April 23, 2025 16:01
@andreibratu andreibratu changed the title Release 0.8.31 Release 0.8.36: Agents Support in SDK Apr 24, 2025
@andreibratu andreibratu changed the title Release 0.8.36: Agents Support in SDK Release 0.8.36b1: Agents Support in SDK Apr 24, 2025
@andreibratu andreibratu force-pushed the add-agents-sdk branch 3 times, most recently from cb295f3 to 914091b Compare April 25, 2025 10:20
@andreibratu andreibratu marked this pull request as ready for review April 25, 2025 11:52


def _safe_get_default_file_version(client: "BaseHumanloop", file_config: FileEvalConfig) -> EvaluatedFile:
"""Get default version of a File from online workspace.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit (non-blocking): "remote" workspace?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ack

subclient = _get_subclient(client=client, file_config=file_config)
return subclient.get(id=file_id)
else:
raise HumanloopRuntimeError("You must provide a path or id in your `file` config.")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe "You must provide either a path or id in your file config". Or something to indicate it's an XOR

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ack


if type == "flow":
if type_ == "flow":
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no agent here? Why can't you upsert? From what I can tell this upserts based on the version param in eval.run?

Comment on lines -549 to -551
elif type == "evaluator":
hl_file = client.evaluators.upsert(**file_dict) # type: ignore [arg-type, assignment]

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also is removing this a breaking change?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

more of some hanging code, we do not support evals.run on evaluators

Comment on lines 1131 to 1137
<<<<<<< HEAD
"2024-07-08 21:40:35+00:00",
),
end_time=datetime.datetime.fromisoformat(
"2024-07-08 21:40:39+00:00",
=======
"2024-07-08 19:40:35+00:00",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

merge conflicts?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

Comment on lines +119 to +132
def print_error(message: str) -> None:
"""Print a formatted error message to stdout."""
sys.stdout.write(f"{RED}{message}{RESET}")


def print_warning(message: str) -> None:
"""Print a formatted warning message to stdout."""
sys.stdout.write(f"{YELLOW}{message}{RESET}\n")


def print_info(message: str) -> None:
"""Print a formatted info message to stdout."""
sys.stdout.write(f"{CYAN}{message}{RESET}\n")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

much nicer thank you for this

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ack <3

Copy link
Contributor

@jamesbaskerville jamesbaskerville left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a few comments/possible fixes, but generally lgtm. Didn't look at all the autogenerated code, but the enum of events seems reasonable.

@andreibratu andreibratu force-pushed the add-agents-sdk branch 3 times, most recently from 4ba6bb5 to 52736e3 Compare April 29, 2025 11:44
@andreibratu andreibratu merged commit 5535c9c into master Apr 30, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants