Skip to content
This repository was archived by the owner on Mar 25, 2026. It is now read-only.
This repository was archived by the owner on Mar 25, 2026. It is now read-only.

Model content should include top-level text nodes #34

@cbotman

Description

@cbotman

The Inline Content example (and others) are actually wrong at the moment. E.g.

<a href="#inline" class="inline">Show</a>
<div id="inline">
        Inline content goes here...
</div>
JS$(".inline").modaal();

This is because this line in create_basic:
content = target.children().clone(true,true);

Should be:
content = target.contents().clone(true,true);

Otherwise we're not grabbing top-level text nodes. Need to review the other modal creation methods for the same issue too.

Until this is fixed, an example like the above will show an empty modal. You can get around that by wrapping "Inline content goes here..." with an element. E.g. div, span, p

Metadata

Metadata

Assignees

Type

No type
No fields configured for issues without a type.

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions