kernel: move some doc comments for GAPState members

hulpke · Dec 14, 2022 · bb861ab · bb861ab
1 parent c7cff9d
commit bb861ab
Show file tree

Hide file tree

Showing 6 changed files with 28 additions and 75 deletions.
diff --git a/src/gapstate.h b/src/gapstate.h
@@ -41,6 +41,9 @@ typedef struct GAPState {
 #endif
 
     /* From intrprtr.c */
+
+    // 'Tilde' is the object referenced by the operator '~', used in
+    // expressions such as '[ [ 1, 2 ], ~[ 1 ] ]'.
     Obj  Tilde;
 
     // The current assertion level for use in Assert
@@ -50,13 +53,33 @@ typedef struct GAPState {
     Obj CurrNamespace;
 
     /* From vars.c */
-    Bag   CurrLVars;
+
+    // 'CurrLVars' is the bag containing the values of the local variables of
+    // the currently executing interpreted function.
+    //
+    // Assignments to the local variables change this bag. We do not call
+    // 'CHANGED_BAG' for each of such change. Instead we wait until a garbage
+    // collection begins and then call 'CHANGED_BAG' in 'BeginCollectBags'.
+    Bag CurrLVars;
+
+    // 'PtrLVars' is a pointer to the 'CurrLVars' bag. This makes it faster to
+    // access local variables.
+    //
+    // Since a garbage collection may move this bag around, the pointer
+    // 'PtrLVars' must be recalculated afterwards in 'VarsAfterCollectBags'.
     Obj * PtrLVars;
+
     Bag   LVarsPool[16];
 
     /* From read.c */
     jmp_buf ReadJmpError;
 
+    // 'Prompt' holds the string that is to be printed if a new line is read
+    // from the interactive files '*stdin*' or '*errin*'.
+    //
+    // It is set to 'gap> ' or 'brk> ' in the read-eval-print loops and
+    // changed to the partial prompt '> ' in 'Read' after the first symbol is
+    // read.
     char Prompt[80];
 
     /* From stats.c */
@@ -69,6 +92,8 @@ typedef struct GAPState {
     ExecStatFunc * CurrExecStatFuncs;
 
     /* From code.c */
+
+    // A pointer to the current function body being executed
     void * PtrBody;
 
     /* From opers.c */

diff --git a/src/gvars.c b/src/gvars.c
@@ -578,8 +578,6 @@ Obj ExprGVar ( UInt gvar )
 
 #define NSCHAR '@'
 
-/* TL: Obj CurrNamespace = 0; */
-
 static Obj FuncSET_NAMESPACE(Obj self, Obj str)
 {
     STATE(CurrNamespace) = str;

diff --git a/src/intrprtr.c b/src/intrprtr.c
@@ -1918,13 +1918,10 @@ void IntrFalseExpr(IntrState * intr)
 
 /****************************************************************************
 **
-*F  IntrTildeExpr()  . . . . . . . . . . . . interpret tilde expression
+*F  IntrTildeExpr() . . . . . . . . . . . . . . .  interpret tilde expression
 **
 **  'IntrTildeExpr' is the action to interpret a tilde expression.
 **
-**  'Tilde' is the identifier for the operator '~', used in
-**  expressions such as '[ [ 1, 2 ], ~[ 1 ] ]'.
-**
 */
 void IntrTildeExpr(IntrState * intr)
 {
@@ -1936,7 +1933,7 @@ void IntrTildeExpr(IntrState * intr)
         return;
     }
 
-    if(! (STATE(Tilde)) ) {
+    if (!STATE(Tilde)) {
         // this code should be impossible to reach, the parser won't allow us
         // to get here; but we leave it here out of paranoia
         ErrorQuit("'~' does not have a value here", 0, 0);

diff --git a/src/io.h b/src/io.h
@@ -272,18 +272,6 @@ UInt OpenInputLogStream(Obj stream);
 */
 UInt CloseInputLog(void);
 
-/****************************************************************************
- **
- *V  Prompt  . . . . . . . . . . . . . . . . . . . . . . prompt to be printed
- **
- **  'Prompt' holds the string that is to be printed if a  new  line  is read
- **  from the interactive files '*stdin*' or '*errin*'.
- **
- **  It is set to 'gap> ' or 'brk> ' in the read-eval-print loops and changed
- **  to the partial prompt '> ' in 'Read' after the first symbol is read.
- */
-/* TL: extern  const Char *    Prompt; */
-
 /****************************************************************************
 **
 *F  SetPrompt( <prompt> ) . . . . . . . . . . . . . set the user input prompt

diff --git a/src/vars.c b/src/vars.c
@@ -45,21 +45,6 @@
 
 #include <stdio.h>
 
-
-/****************************************************************************
-**
-*V  CurrLVars   . . . . . . . . . . . . . . . . . . . . . local variables bag
-**
-**  'CurrLVars'  is the bag containing the  values  of the local variables of
-**  the currently executing interpreted function.
-**
-**  Assignments  to  the local variables change   this bag.  We  do  not call
-**  'CHANGED_BAG' for  each of such change.  Instead we wait until  a garbage
-**  collection begins  and then  call  'CHANGED_BAG'  in  'BeginCollectBags'.
-*/
-/* TL: Bag CurrLVars; */
-
-
 /****************************************************************************
 **
 *V  BottomLVars . . . . . . . . . . . . . . . . .  bottom local variables bag
@@ -72,19 +57,6 @@
 static Bag BottomLVars;
 
 
-/****************************************************************************
-**
-*V  PtrLVars  . . . . . . . . . . . . . . . .  pointer to local variables bag
-**
-**  'PtrLVars' is a pointer to the 'STATE(CurrLVars)' bag.  This  makes it faster to
-**  access local variables.
-**
-**  Since   a   garbage collection may  move   this  bag  around, the pointer
-**  'PtrLVars' must be recalculated afterwards in 'VarsAfterCollectBags'.
-*/
-/* TL: Obj * PtrLVars; */
-
-
 /****************************************************************************
 **
 *F  ObjLVar(<lvar>) . . . . . . . . . . . . . . . . value of a local variable

diff --git a/src/vars.h b/src/vars.h
@@ -25,40 +25,13 @@
 #include "objects.h"
 
 
-/****************************************************************************
-**
-*V  CurrLVars   . . . . . . . . . . . . . . . . . . . . . local variables bag
-**
-**  'CurrLVars'  is the bag containing the  values  of the local variables of
-**  the currently executing interpreted function.
-**
-**  Assignments  to  the local variables change   this bag.  We  do  not call
-**  'CHANGED_BAG' for  each of such change.  Instead we wait until  a garbage
-**  collection begins  and then  call  'CHANGED_BAG'  in  'BeginCollectBags'.
-*/
-/* TL: extern  Bag             CurrLVars; */
-
-
 /****************************************************************************
 **
 *F  IsBottomLVars(<lvars>) . . test whether lvars is at the call stack bottom
 */
 BOOL IsBottomLVars(Obj lvars);
 
 
-/****************************************************************************
-**
-*V  PtrLVars  . . . . . . . . . . . . . . . .  pointer to local variables bag
-**
-**  'PtrLVars' is a pointer to the 'CurrLVars' bag.  This  makes it faster to
-**  access local variables.
-**
-**  Since   a   garbage collection may  move   this  bag  around, the pointer
-**  'PtrLVars' must be recalculated afterwards in 'VarsAfterCollectBags'.
-*/
-/* TL: extern  Obj *           PtrLVars; */
-
-
 /****************************************************************************
 **
 *F  IS_LVARS_OR_HVARS()