kernel: move most system #includes out of common.h

... and into the files that actually need them. That minimizes the risk of
header conflicts, and also may be desirable for who code linking against GAP
which may for some reason or another not want to #include certain system
headers.

src/bits_intern.h

@@ -13,6 +13,8 @@
 
 #include "system.h"
 
+#include <string.h>
+
 
 #define ALL_BITS_UINT  (~(UInt)0)
 

src/boehm_gc.c

@@ -33,6 +33,11 @@
 #include "hpc/thread.h"
 #endif
 
+#include <stdio.h>
+#include <stdlib.h>
+#include <string.h>
+
+
 #ifndef WARD_ENABLED
 
 static inline Bag * DATA(BagHeader * bag)

src/common.h

@@ -14,12 +14,7 @@
 #include "config.h"
 
 #include <assert.h>
-#include <limits.h>
-#include <setjmp.h>
 #include <stdint.h>
-#include <stdio.h>
-#include <stdlib.h>
-#include <string.h>
 
 #include "debug.h"
 

src/debug.c

@@ -28,6 +28,9 @@
 #include "hpc/region.h"
 #endif
 
+#include <stdio.h>
+#include <stdlib.h>
+
 #if defined(HAVE_BACKTRACE) && defined(GAP_PRINT_BACKTRACE)
 #include <execinfo.h>
 #include <signal.h>

src/error.c

@@ -35,6 +35,8 @@
 #include "hpc/thread.h"
 #endif
 
+#include <stdio.h>
+
 
 static Obj ErrorInner;
 static Obj ERROR_OUTPUT = NULL;

src/funcs.c

@@ -39,6 +39,9 @@
 #include "hpc/thread.h"
 #endif
 
+#include <stdlib.h>
+
+
 static ModuleStateOffset FuncsStateOffset = -1;
 
 struct FuncsModuleState {

src/gasman.c

@@ -123,6 +123,8 @@
 
 #include "bags.inc"
 
+#include <string.h>
+
 #ifdef GAP_MEM_CHECK
 #include <sys/mman.h>
 #endif

src/gvars.c

@@ -48,6 +48,8 @@
 #include <pthread.h>
 #endif
 
+#include <stdio.h>
+
 
 #ifdef HPCGAP
 #define USE_GVAR_BUCKETS

src/hookintrprtr.c

@@ -22,6 +22,8 @@
 
 #include "hpc/thread.h"
 
+#include <string.h>
+
 
 /* List of active hooks */
 struct InterpreterHooks * activeHooks[HookCount];

src/hpc/aobjects.c

@@ -33,6 +33,8 @@
 #include "records.h"
 #include "stringobj.h"
 
+#include <stdlib.h>
+
 
 static Obj TYPE_ALIST;
 static Obj TYPE_AREC;

src/hpc/misc.c

@@ -10,6 +10,7 @@
 
 #include "hpc/misc.h"
 
+#include <stdlib.h>
 #include <string.h>
 
 /****************************************************************************

src/hpc/thread.c

@@ -28,6 +28,7 @@
 #include <errno.h>
 #include <pthread.h>
 #include <stdio.h>
+#include <stdlib.h>
 #include <sys/mman.h>
 #include <unistd.h>
 

src/hpc/threadapi.c

@@ -39,8 +39,9 @@
 #include "hpc/tls.h"
 #include "hpc/traverse.h"
 
-#include <stdio.h>
 #include <signal.h>
+#include <stdio.h>
+#include <stdlib.h>
 #include <sys/time.h>
 
 #include <pthread.h>

src/hpc/tls.c

@@ -11,6 +11,8 @@
 #include "gapstate.h"
 #include "hpc/thread.h"
 
+#include <string.h>
+
 #ifdef USE_NATIVE_TLS
 
 __thread GAPState TLSGAPtate;

src/io.c

@@ -41,6 +41,8 @@
 #include "hpc/aobjects.h"
 #endif
 
+#include <limits.h>
+
 
 /****************************************************************************
 **

src/libgap-api.c

@@ -36,6 +36,8 @@
 #include "streams.h"
 #include "stringobj.h"
 
+#include <stdio.h>
+
 static BOOL UsingLibGap = FALSE;
 
 BOOL IsUsingLibGap(void)

src/macfloat.c

@@ -33,6 +33,10 @@
 #include "stringobj.h"
 #include "sysstr.h"
 
+#include <stdio.h>
+#include <stdlib.h>
+
+
 #define RequireMacFloat(funcname, op) \
     RequireArgumentCondition(funcname, op, IS_MACFLOAT(op), \
         "must be a macfloat")

src/modules.c

@@ -41,6 +41,8 @@
 #include <dlfcn.h>
 #endif
 
+#include <stdio.h>
+
 
 /****************************************************************************
 **

src/objects.c

@@ -38,6 +38,9 @@
 #include "hpc/traverse.h"
 #endif
 
+#include <stdio.h>
+#include <stdlib.h>
+
 
 enum {
     MAXPRINTDEPTH = 64,

src/opers.c

@@ -44,6 +44,9 @@
 #include <pthread.h>
 #endif
 
+#include <stdio.h>
+
+
 /****************************************************************************
 **
 *V  TRY_NEXT_METHOD . . . . . . . . . . . . . . . . .  'TRY_NEXT_METHOD' flag

src/plist.h

@@ -28,6 +28,8 @@
 
 #include "objects.h"
 
+#include <string.h>
+
 /****************************************************************************
 **
 *F  NEW_PLIST(<type>,<plen>)  . . . . . . . . . . . allocate a new plain list

src/precord.c

@@ -47,6 +47,8 @@
 #include "hpc/traverse.h"
 #endif
 
+#include <stdlib.h>
+
 /****************************************************************************
 **
 *F * * * * * * * * * standard functions for plain records * * * * * * * * * *

src/profile.c

@@ -32,6 +32,7 @@
 
 #include "hpc/thread.h"
 
+#include <stdio.h>
 #include <sys/time.h>                   // for gettimeofday
 #include <sys/types.h>
 #include <unistd.h>

src/saveload.c

@@ -30,6 +30,7 @@
 #include "sysfiles.h"
 #include "sysopt.h"
 
+#include <stdio.h>
 #include <unistd.h>
 
 

src/streams.c

@@ -40,6 +40,8 @@
 
 #include <dirent.h>
 #include <errno.h>
+#include <stdlib.h>
+#include <stdio.h>
 #include <time.h>
 #include <unistd.h>
 

src/stringobj.h

@@ -24,6 +24,8 @@
 
 #include "objects.h"
 
+#include <string.h>
+
 
 /****************************************************************************
 **

src/sysfiles.c

@@ -30,16 +30,15 @@
 #include "sysenv.h"
 #include "sysopt.h"
 #include "sysstr.h"
+#include "system.h"
 
 #include "hpc/thread.h"
 
-#ifdef HAVE_LIBREADLINE
-#include <readline/readline.h>
-#endif
-
 #include <assert.h>
 #include <errno.h>
 #include <fcntl.h>
+#include <stdio.h>
+#include <stdlib.h>
 #include <termios.h>
 #include <time.h>
 #include <unistd.h>
@@ -69,6 +68,10 @@ typedef void sig_handler_t ( int );
 #include <process.h>
 #endif
 
+#ifdef HAVE_LIBREADLINE
+#include <readline/readline.h>
+#endif
+
 #include <zlib.h>
 
 

src/sysfiles.h

@@ -16,6 +16,8 @@
 
 #include "system.h"
 
+#include <stddef.h>
+
 
 /****************************************************************************
 **

src/sysjmp.h

@@ -14,6 +14,7 @@
 
 #include "system.h"
 
+#include <setjmp.h>
 
 /****************************************************************************
 **

src/sysmem.c

@@ -23,6 +23,9 @@
 #include <fcntl.h>
 #endif
 
+#include <stdio.h>
+#include <stdlib.h>
+#include <string.h>
 #include <unistd.h>
 
 #ifdef HAVE_MADVISE

src/sysroots.c

@@ -17,6 +17,8 @@
 #include "sysfiles.h"
 #include "sysstr.h"
 
+#include <stdlib.h>
+
 
 /****************************************************************************
 **

src/sysroots.h

@@ -14,6 +14,8 @@
 
 #include "common.h"
 
+#include <stddef.h>
+
 
 /****************************************************************************
 **

src/system.c

@@ -37,6 +37,8 @@
 #include <assert.h>
 #include <fcntl.h>
 #include <stdarg.h>
+#include <stdio.h>
+#include <stdlib.h>
 #include <time.h>
 #include <unistd.h>
 

src/systime.c

@@ -13,6 +13,7 @@
 
 #include "system.h"
 
+#include <stddef.h>
 #include <sys/time.h>
 #include <sys/types.h>
 

src/trans.cc

@@ -64,6 +64,8 @@ extern "C" {
 #include "plist.h"
 #include "saveload.h"
 
+#include <stdio.h>
+
 } // extern "C"
 
 #include "permutat_intern.hh"

src/vars.c

@@ -43,6 +43,9 @@
 #include "hpc/guards.h"
 #endif
 
+#include <stdio.h>
+
+
 /****************************************************************************
 **
 *V  CurrLVars   . . . . . . . . . . . . . . . . . . . . . local variables bag

tst/testkernel/dstruct.c

@@ -4,6 +4,8 @@
 
 #include <libgap-api.h>
 #include <stdio.h>
+#include <stdlib.h>
+#include <string.h>
 
 static int int_cmp(int a, int b)
 {

tst/testlibgap/api.c

@@ -11,9 +11,9 @@
  */
 
 #include "common.h"
+#include "intobj.h"
 
-#include <intobj.h>
-
+#include <string.h>
 
 void records(void)
 {

tst/testlibgap/wsload.c

@@ -3,6 +3,9 @@
  * Also shows how to directly pass command line arguments to libgap.
  */
 #include "common.h"
+
+#include <string.h>
+
 int main(int argc, char ** argv)
 {
     char *args[50];