Skip to content

Commit

Permalink
Remove unused local variables in files starting "a"
Browse files Browse the repository at this point in the history
  • Loading branch information
james-d-mitchell authored and fingolfin committed Dec 16, 2022
1 parent 9a875fd commit 191df04
Show file tree
Hide file tree
Showing 6 changed files with 13 additions and 15 deletions.
2 changes: 0 additions & 2 deletions lib/algebra.gi
Original file line number Diff line number Diff line change
Expand Up @@ -2056,7 +2056,6 @@ InstallMethod( ViewObj,
"for an algebra-with-one with known generators",
[ IsAlgebraWithOne and HasGeneratorsOfAlgebraWithOne ],
function( A )
local nrgens;
Print( "<algebra-with-one over ", LeftActingDomain( A ), ", with ",
Pluralize( Length( GeneratorsOfAlgebraWithOne( A ) ), "generator" ),
">" );
Expand Down Expand Up @@ -2113,7 +2112,6 @@ InstallMethod( ViewObj,
"for a Lie algebra with known generators",
[ IsLieAlgebra and HasGeneratorsOfAlgebra ],
function( A )
local nrgens;
Print( "<Lie algebra over ", LeftActingDomain( A ), ", with ",
Pluralize( Length( GeneratorsOfAlgebra( A ) ), "generator" ), ">" );
end );
Expand Down
6 changes: 3 additions & 3 deletions lib/algfld.gi
Original file line number Diff line number Diff line change
Expand Up @@ -485,7 +485,7 @@ end);
##
InstallMethod(\*,"AlgElm*AlgElm",IsIdenticalObj,[IsKroneckerConstRep,IsKroneckerConstRep],0,
function(x,y)
local fam,b,d,i;
local fam,b,i;
fam:=FamilyObj(x);
b:=ProductCoeffs(x![1],y![1]);
while Length(b)<fam!.deg do
Expand Down Expand Up @@ -1072,7 +1072,7 @@ local l,f,i,j,k,gens;
end);

InstallGlobalFunction(AlgExtEmbeddedPol,function(ext,pol)
local f, cof;
local cof;
cof:=CoefficientsOfUnivariatePolynomial(pol);
return UnivariatePolynomial(ext,cof*One(ext),
IndeterminateNumberOfUnivariateRationalFunction(pol));
Expand Down Expand Up @@ -1353,7 +1353,7 @@ end);
##
InstallGlobalFunction(IdealDecompositionsOfPolynomial,function(f)
local n,e,ff,p,ffp,ffd,roots,allroots,nowroots,fm,fft,comb,combi,k,h,i,j,
gut,avoid,blocks,g,m,decom,z,R,scale,allowed,hp,hpc,a,kfam,only;
gut,avoid,blocks,g,m,decom,z,allowed,hp,hpc,a,kfam,only;

only:=ValueOption("onlyone")=true;
n:=DegreeOfUnivariateLaurentPolynomial(f);
Expand Down
2 changes: 1 addition & 1 deletion lib/alghom.gi
Original file line number Diff line number Diff line change
Expand Up @@ -502,7 +502,7 @@ InstallMethod( IsSingleValued,
"for algebra g.m.b.i.",
[ IsGeneralMapping and IsAlgebraGeneralMappingByImagesDefaultRep ],
function(map)
local S,gi,i,basic;
local S;
S:=Source(map);

# rewriting to left modules is not feasible for infinite dimensional
Expand Down
2 changes: 1 addition & 1 deletion lib/alglie.gi
Original file line number Diff line number Diff line change
Expand Up @@ -1165,7 +1165,7 @@ end);
InstallMethod( PClosureSubalgebra, "for a subalgebra of restricted jacobian elements",
[ IsLieAlgebra and IsJacobianElementCollection ],
function(A)
local i, p, oldA;
local i, oldA;

repeat
oldA := A;
Expand Down
2 changes: 1 addition & 1 deletion lib/algliess.gi
Original file line number Diff line number Diff line change
Expand Up @@ -1349,7 +1349,7 @@ SimpleLieAlgebraTypeM := function (n, F)
# that
# p = coeff * OBasis [pos].
WOProduct := function (w1, x2)
local pow, prod;
local pow;
if x2 [w1 [2]] > 0 then
pow := ShallowCopy (x2);
pow [w1 [2]] := pow [w1 [2]] - 1;
Expand Down
14 changes: 7 additions & 7 deletions lib/autsr.gi
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,7 @@ end;
# of representatives and can be used to deduce the module automorphism
# belonging to a factor group automorphism.
BindGlobal("AGSRFindRels",function(nat,newgens)
local C,M,p,all,gens,sub,q,hom,fp,rels,new,pre,sel,i,free,cnt;
local C,M,p,all,gens,sub,q,hom,fp,rels,new,pre,i,free,cnt;
M:=KernelOfMultiplicativeGeneralMapping(nat);
C:=Centralizer(Source(nat),M);
if not IsSubset(FrattiniSubgroup(C),M) then
Expand Down Expand Up @@ -334,7 +334,7 @@ end);
# First try `SubgroupProperty`, but when it stalls attempt to find
# minimal supergroups and prove that none of them satisfies.
BindGlobal("SubgroupConditionAboveAux",function(G,cond,S1,avoid)
local S,c,hom,q,a,b,i,t,int,bad,have,ups,up,new,u,good,abort,clim,worked,pp,
local S,c,hom,q,a,b,i,t,have,ups,new,u,good,abort,clim,worked,pp,
cnt,locond,tstcnt,setupc,havetest;

setupc:=function()
Expand Down Expand Up @@ -704,7 +704,7 @@ end);
# component subgroups, orbits
BindGlobal("AutomGrpSR",function(G)
local ff,r,d,ser,u,v,i,j,k,p,bd,e,gens,lhom,M,N,hom,Q,Mim,q,ocr,split,MPcgs,
b,fratsim,AQ,OQ,Zm,D,innC,bas,oneC,imgs,C,maut,innB,tmpAut,imM,a,A,B,
b,fratsim,AQ,OQ,Zm,D,innC,oneC,imgs,C,maut,innB,tmpAut,imM,a,A,B,
cond,sub,AQI,AQP,AQiso,rf,res,resperm,proj,Aperm,Apa,precond,ac,
comiso,extra,mo,rada,makeaqiso,ind,lastperm,actbase,somechar,stablim,
scharorb,asAutom,jorb,jorpo,substb,isBadPermrep,ma,nosucl,nosuf,rlgf;
Expand Down Expand Up @@ -1143,7 +1143,7 @@ local ff,r,d,ser,u,v,i,j,k,p,bd,e,gens,lhom,M,N,hom,Q,Mim,q,ocr,split,MPcgs,
ocr:=AGSRPrepareAutomLift( Q, MPcgs, q );

precond:=function(perm)
local aut,newgens,mo2,iso,a;
local aut,newgens,mo2;
if perm in Aperm then
return true;
fi;
Expand Down Expand Up @@ -1547,7 +1547,7 @@ end);
BindGlobal("AGSRMatchedCharacteristics",function(g,h)
local a,props,cg,ch,clg,clh,ng,nh,coug,couh,pg,ph,i,j,stop,coinc;
props:=function(a,chars)
local p,b,i,r,der;
local p,b,der;
der:=function(u)
if u in chars then
Add(p,-Position(chars,u));
Expand Down Expand Up @@ -1699,8 +1699,8 @@ end);
# only of use as long as we don't yet have a Cannon/Holt version of
# isomorphism available and there are many generators
InstallGlobalFunction(PatheticIsomorphism,function(G,H)
local d,a,map,possibly,cG,cH,nG,nH,i,j,sel,u,v,asAutomorphism,K,L,conj,e1,e2,
iso,api,good,gens,pre,aab,as;
local d,a,map,possibly,cG,nG,nH,i,j,u,v,asAutomorphism,K,L,conj,e1,e2,
iso,api,gens,pre,aab,as;

possibly:=function(a,b)
if Size(a)<>Size(b) then
Expand Down

0 comments on commit 191df04

Please sign in to comment.