mat8bit: add tests for higher code coverage

Everything in mat8bit.gi is covered except RepresentationsOfMatrix which doesn't seem to be used anywhere, and also doesn't seem like it should really be in mat8bit.gi at all. Also removed some unreachable code.
hulpke · Feb 9, 2023 · 076b3e9 · 076b3e9
1 parent 1df0e2c
commit 076b3e9
Show file tree

Hide file tree

Showing 2 changed files with 420 additions and 5 deletions.
diff --git a/lib/mat8bit.gi b/lib/mat8bit.gi
@@ -254,9 +254,8 @@ InstallGlobalFunction(ConvertToMatrixRep,
 
     LeastCommonPower := function(qs)
         local p, d, x, i;
-        if Length(qs) = 0 then
-            return fail;
-        fi;
+        Assert(1, Length(qs) > 0);
+
         x := Z(qs[1]);
         p := Characteristic(x);
         d := DegreeFFE(x);
@@ -270,7 +269,6 @@ InstallGlobalFunction(ConvertToMatrixRep,
         return p^d;
     end;
 
-
     qs := [];
 
     m := arg[1];