Fixing crashing bug with reset callback after closed #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's a scenario with this plugin's use inside flutterflow where if you have a stop / reset command callback on timer end, and the widget has disposed already before the callback a main thread crash occurs with the following trace:
broadcast_stream_controller.dart - Line 243
BroadcastStreamController.add (#3) + 243
subject.dart - Line 151
Subject._add + 151
subject.dart - Line 141
Subject.add (#3) + 141
stop_watch_timer.dart - Line 406
StopWatchTimer._reset + 406
stop_watch_timer.dart - Line 270
FlutterFlowTimerController.onResetTimer + 270