Updated CHANGELOG and fixing broken tests

.travis.yml

@@ -9,14 +9,17 @@ rvm:
   - 2.0.0
 bundler_args: --without system_tests
 env:
-  matrix:
+  - PUPPET_VERSION=4.4.1
   - PUPPET_VERSION=3.7.3
   - PUPPET_VERSION=3.6.0
-  - PUPPET_VERSION=3.5.0
+  - PUPPET_VERSION=3.5.1
   - PUPPET_VERSION=3.4.2
   - PUPPET_VERSION=3.3.1
   - PUPPET_VERSION=3.2.3
   - PUPPET_VERSION=2.7.21
-  global:
-  - PUBLISHER_LOGIN=huit
-  - secure: Ijc9NOKcofDC+i0afauvFj7P6vqtThbeMnjuOYxaqcMPfM4f+IrxpzyoIjOzDbD83b0vMYCSItPW/RExVINkwhjghfzPhMsbjfA2XfcvWYMxCOsvXR3TMHSNyPGD7ITbitUDofJ0TTIfZQwE10SeI8MhfL61a4eiR2QNQhDyraI=
+matrix:
+  exclude:
+   - rvm: 1.8.7
+     env: PUPPET_VERSION=4.4.1
+   - rvm: 2.0.0
+     env: PUPPET_VERSION=2.7.21

CHANGELOG

@@ -1,3 +1,5 @@
+1.7.2 - Ben Roberts <me@benroberts.net> 
+  * Fix comparison of @localusers to undef for puppet3.7/ruby1.8
 1.7.1 - Tim Hartmann <tfhartmann@gmail.com> 
   * Fixes issue #54 by adding configure_outputs parameter
 1.7.0 - Joe Eaves <jinux@alluha.net>, Tim Hartmann <tfhartmann@gmail.com> 

Gemfile

@@ -1,28 +1,37 @@
 source ENV['GEM_SOURCE'] || "https://rubygems.org"
 
 group :development, :unit_tests do
-  gem 'rake',                    :require => false
-  gem 'rspec-core', '3.1.7',     :require => false
   gem 'rspec-puppet',            :require => false
   gem 'puppetlabs_spec_helper',  :require => false
   gem 'puppet-lint',             :require => false
   gem 'simplecov',               :require => false
   gem 'puppet_facts',            :require => false
   gem 'json',                    :require => false
+  gem 'iconv',                   :require => false
 end
 
 group :system_tests do
   gem 'beaker-rspec',  :require => false
   gem 'serverspec',    :require => false
 end
 
+if rubyversion = `ruby --version`
+  if rubyversion =~ /1.8.7/
+    gem 'rake',       '10.3.2',    :require => false
+    gem 'rspec-core', '2.99.2',    :require => false
+  end 
+else
+  gem 'rake',                  :require => false
+  gem 'rspec-core', '3.1.7',   :require => false
+end
+
 if facterversion = ENV['FACTER_GEM_VERSION']
   gem 'facter', facterversion, :require => false
 else
   gem 'facter', :require => false
 end
 
-if puppetversion = ENV['PUPPET_GEM_VERSION']
+if puppetversion = ENV['PUPPET_VERSION']
   gem 'puppet', puppetversion, :require => false
 else
   gem 'puppet', :require => false

manifests/init.pp

@@ -108,7 +108,7 @@
   $localusers        = $::splunk::params::localusers,
   $licenseserver     = undef,
   $nagios_contacts   = $::splunk::params::nagios_contacts,
-  $nagiosserver      = $::splunk::nagiosserver,
+  $nagiosserver      = undef,
   $output_hash       = $::splunk::params::output_hash,
   $port              = $::splunk::params::port,
   $proxyserver       = $::splunk::params::proxyserver,