Sort in template fails

[pjelar]

I get this error:

Error: Could not retrieve catalog from remote server: Error 400 on SERVER: Failed to parse template splunk/opt/splunk/etc/system/local/outputs.conf.erb:
  Filepath: /etc/puppetlabs/puppet/modules/splunk/templates/opt/splunk/etc/system/local/outputs.conf.erb
  Line: 4
  Detail: undefined method `sort' for "example1,example2":String
 at /etc/puppetlabs/puppet/modules/splunk/manifests/outputs.pp:62

I'm using puppet enterprise pe-puppet-3.4.3.6-1.pe.el6.noarch.

Where does the sort function come from? Do I need an extra plugin?

Thanks,
Pierre

[tfhartmann]

Hi Pierre

That sort function should come from the ruby version that ships with puppet PE. Do you know which version of ruby it uses? It' would probably behoove us toads puppet-pe to the unit test for this module actually. I'll see if I can help get this sorted!

[andrewh]

The clue is here:

Detail: undefined method `sort' for "example1,example2":String

You have passed a string to your template.

The template is probably using Array#sort: http://ruby-doc.org/core-1.8.7/Array.html#method-i-sort

If you pass ["example1", "example2"] to your template it should work.

[pjelar]

/opt/puppet/bin
./ruby -v
ruby 1.9.3p484 (2013-11-22 revision 43786) [x86_64-linux]
rpm -qf ruby 
pe-ruby-1.9.3.484-6.pe.el6.x86_64

Default values in params.pp

  $target_group     = { example1 => 'server1.example.com',
                        example2 => 'server2.example.com' }

[andrewh]

Same issue, except the template is using Hash#sort:

http://ruby-doc.org/core-1.8.7/Hash.html#method-i-sort

It appears this method is included from Enumerable in 1.9:

http://ruby-doc.org/core-1.9.3/Enumerable.html#method-i-sort

[tfhartmann]

@andrewh @pjelar Thanks guys, I've opened a bug branch and will work on adding support for Ruby 1.9.3-p484, tests all still pas for 1.8.7-p358 which is what I was using. Looks like the following tests fail under 1.9.3-p484

Failures:

  1) splunk::outputs Splunk outputs private sub class on RedHat platform
     Failure/Error: it { should create_class('splunk::outputs') }
     Puppet::Error:
       Failed to parse template splunk/opt/splunk/etc/system/local/outputs.conf.erb:
         Filepath: /Users/alaric/git/puppet-splunk/spec/fixtures/modules/splunk/templates/opt/splunk/etc/system/local/outputs.conf.erb
         Line: 4
         Detail: undefined method `sort' for "example1":String
        at /Users/alaric/git/puppet-splunk/spec/fixtures/modules/splunk/manifests/outputs.pp:62 on node preator.local
     # ./spec/classes/splunk_ouputs_spec.rb:15:in `block (4 levels) in <top (required)>'

  2) splunk::outputs Splunk outputs private sub class on RedHat platform
     Failure/Error: )
     Puppet::Error:
       Failed to parse template splunk/opt/splunk/etc/system/local/outputs.conf.erb:
         Filepath: /Users/alaric/git/puppet-splunk/spec/fixtures/modules/splunk/templates/opt/splunk/etc/system/local/outputs.conf.erb
         Line: 4
         Detail: undefined method `sort' for "example1":String
        at /Users/alaric/git/puppet-splunk/spec/fixtures/modules/splunk/manifests/outputs.pp:62 on node preator.local
     # ./spec/classes/splunk_ouputs_spec.rb:23:in `block (4 levels) in <top (required)>'

  3) splunk::outputs Splunk outputs private sub class on RedHat platform
     Failure/Error: it { should contain_file('/opt/splunk/etc/system/local/outputs.conf').with_content(/[tcpout]/) }
     Puppet::Error:
       Failed to parse template splunk/opt/splunk/etc/system/local/outputs.conf.erb:
         Filepath: /Users/alaric/git/puppet-splunk/spec/fixtures/modules/splunk/templates/opt/splunk/etc/system/local/outputs.conf.erb
         Line: 4
         Detail: undefined method `sort' for "example1":String
        at /Users/alaric/git/puppet-splunk/spec/fixtures/modules/splunk/manifests/outputs.pp:62 on node preator.local
     # ./spec/classes/splunk_ouputs_spec.rb:25:in `block (4 levels) in <top (required)>'

  4) splunk::outputs Splunk outputs private sub class on RedHat platform
     Failure/Error: it { should contain_file('/opt/splunk/etc/system/local/outputs.conf').with_content(/defaultGroup = example1/) }
     Puppet::Error:
       Failed to parse template splunk/opt/splunk/etc/system/local/outputs.conf.erb:
         Filepath: /Users/alaric/git/puppet-splunk/spec/fixtures/modules/splunk/templates/opt/splunk/etc/system/local/outputs.conf.erb
         Line: 4
         Detail: undefined method `sort' for "example1":String
        at /Users/alaric/git/puppet-splunk/spec/fixtures/modules/splunk/manifests/outputs.pp:62 on node preator.local
     # ./spec/classes/splunk_ouputs_spec.rb:26:in `block (4 levels) in <top (required)>'

  5) splunk::outputs Splunk outputs private sub class on RedHat platform
     Failure/Error: it { should contain_file('/opt/splunk/etc/system/local/outputs.conf').with_content(/disabled = false/) }
     Puppet::Error:
       Failed to parse template splunk/opt/splunk/etc/system/local/outputs.conf.erb:
         Filepath: /Users/alaric/git/puppet-splunk/spec/fixtures/modules/splunk/templates/opt/splunk/etc/system/local/outputs.conf.erb
         Line: 4
         Detail: undefined method `sort' for "example1":String
        at /Users/alaric/git/puppet-splunk/spec/fixtures/modules/splunk/manifests/outputs.pp:62 on node preator.local
     # ./spec/classes/splunk_ouputs_spec.rb:27:in `block (4 levels) in <top (required)>'

  6) splunk::outputs Splunk outputs private sub class on RedHat platform
     Failure/Error: it { should contain_file('/opt/splunk/etc/system/local/outputs.conf').with_content(/tcpout:example1/) }
     Puppet::Error:
       Failed to parse template splunk/opt/splunk/etc/system/local/outputs.conf.erb:
         Filepath: /Users/alaric/git/puppet-splunk/spec/fixtures/modules/splunk/templates/opt/splunk/etc/system/local/outputs.conf.erb
         Line: 4
         Detail: undefined method `sort' for "example1":String
        at /Users/alaric/git/puppet-splunk/spec/fixtures/modules/splunk/manifests/outputs.pp:62 on node preator.local
     # ./spec/classes/splunk_ouputs_spec.rb:28:in `block (4 levels) in <top (required)>'

  7) splunk::outputs Splunk outputs private sub class on RedHat platform
     Failure/Error: it { should contain_file('/opt/splunk/etc/system/local/outputs.conf').with_content(/server = server1.example.com:50514/) }
     Puppet::Error:
       Failed to parse template splunk/opt/splunk/etc/system/local/outputs.conf.erb:
         Filepath: /Users/alaric/git/puppet-splunk/spec/fixtures/modules/splunk/templates/opt/splunk/etc/system/local/outputs.conf.erb
         Line: 4
         Detail: undefined method `sort' for "example1":String
        at /Users/alaric/git/puppet-splunk/spec/fixtures/modules/splunk/manifests/outputs.pp:62 on node preator.local
     # ./spec/classes/splunk_ouputs_spec.rb:29:in `block (4 levels) in <top (required)>'

  8) splunk on RedHat platform Splunk class with no parameters, basic test
     Failure/Error: should compile
     Puppet::Error:
       Failed to parse template splunk/opt/splunk/etc/system/local/outputs.conf.erb:
         Filepath: /Users/alaric/git/puppet-splunk/spec/fixtures/modules/splunk/templates/opt/splunk/etc/system/local/outputs.conf.erb
         Line: 4
         Detail: undefined method `sort' for "example1,example2":String
        at /Users/alaric/git/puppet-splunk/spec/fixtures/modules/splunk/manifests/outputs.pp:62 on node preator.local
     # ./spec/classes/splunk_spec.rb:10:in `block (4 levels) in <top (required)>'

  9) splunk on RedHat platform With type param set to 'lwf'
     Failure/Error: should compile
     Puppet::Error:
       Failed to parse template splunk/opt/splunk/etc/system/local/outputs.conf.erb:
         Filepath: /Users/alaric/git/puppet-splunk/spec/fixtures/modules/splunk/templates/opt/splunk/etc/system/local/outputs.conf.erb
         Line: 4
         Detail: undefined method `sort' for "example1,example2":String
        at /Users/alaric/git/puppet-splunk/spec/fixtures/modules/splunk/manifests/outputs.pp:62 on node preator.local
     # ./spec/classes/splunk_spec.rb:24:in `block (4 levels) in <top (required)>'

Finished in 1.45 seconds
22 examples, 9 failures

Failed examples:

rspec ./spec/classes/splunk_ouputs_spec.rb:15 # splunk::outputs Splunk outputs private sub class on RedHat platform
rspec ./spec/classes/splunk_ouputs_spec.rb:16 # splunk::outputs Splunk outputs private sub class on RedHat platform
rspec ./spec/classes/splunk_ouputs_spec.rb:25 # splunk::outputs Splunk outputs private sub class on RedHat platform
rspec ./spec/classes/splunk_ouputs_spec.rb:26 # splunk::outputs Splunk outputs private sub class on RedHat platform
rspec ./spec/classes/splunk_ouputs_spec.rb:27 # splunk::outputs Splunk outputs private sub class on RedHat platform
rspec ./spec/classes/splunk_ouputs_spec.rb:28 # splunk::outputs Splunk outputs private sub class on RedHat platform
rspec ./spec/classes/splunk_ouputs_spec.rb:29 # splunk::outputs Splunk outputs private sub class on RedHat platform
rspec ./spec/classes/splunk_spec.rb:9 # splunk on RedHat platform Splunk class with no parameters, basic test
rspec ./spec/classes/splunk_spec.rb:23 # splunk on RedHat platform With type param set to 'lwf'
/opt/boxen/rbenv/versions/1.9.3-p484/bin/ruby -S rspec spec/classes/splunk_config_license_spec.rb spec/classes/splunk_inputs_spec.rb spec/classes/splunk_ouputs_spec.rb spec/classes/splunk_service_spec.rb spec/classes/splunk_spec.rb --color failed

[tfhartmann]

Just uploaded a new version to github and the forge
https://forge.puppetlabs.com/huit/splunk/1.4.3

Let me know if you run into any more trouble with PE / Ruby 1.9.3 Also, feel free to submit PR if you have a feature of bug you'd like to add :)