refactor: improve clj-kondo linting and add transport factory tests #26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes clj-kondo warnings to improve code quality and reduce noise in linting output. Changes include: - client-transport/http: Remove unused config binding - http-client: Remove unused imports and build-headers function - in-memory-transport: Remove unused bindings in server and tests, remove unused imports from test files All affected component tests continue to pass.
Add dedicated test functions for registry management functions: - unregister-transport-test: validates transport removal, idempotency, and isolation from other transports - transport-registered-test: validates registration checks for registered, unregistered, built-in, and non-keyword types Also includes formatting fixes and clojure-lsp ignore annotations.
Remove unused helper functions and simplify code based on clj-kondo analysis: - Remove unused atomic operations (compare-and-set, decrement, add-and-get) - Remove unused queue dequeue function - Remove unused protocol methods and test helpers - Clean up unnecessary imports and bindings - Fix formatting and indentation issues These changes reduce code surface area and eliminate dead code identified by clj-kondo static analysis.
Create comprehensive test suite for server-transport factory with dedicated tests for unregister-transport! and transport-registered?: - unregister-transport-test: validates transport removal, idempotency, and isolation from other transports - transport-registered-test: validates registration checks for registered, unregistered, built-in, and non-keyword types - Additional tests for registration, built-in transports, factory creation, and integration workflows Also updates tests.edn to include server-transport paths and adds clojure-lsp ignore annotations to factory.clj.
Apply additional clj-kondo linting fixes: - Remove unused imports (clojure.java.io) - Prefix unused bindings with underscore - Remove redundant empty string checks - Clean up formatting and whitespace - Remove unused helper functions in tests These changes improve code quality by eliminating dead code and following Clojure best practices.
hugoduncan
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Improve clj-kondo static analysis and apply comprehensive linting fixes across the codebase, plus add missing tests for transport factory functions.
Changes
New Tests
unregister-transport!andtransport-registered?Code Quality Improvements
Impact
Test Results
All tests pass with 0 failures:
Files Changed