Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update _miscellaneous.scss - fadein keyframe #86

Merged
merged 1 commit into from
Jul 26, 2023

Conversation

DavidBThomp
Copy link
Contributor

@DavidBThomp DavidBThomp commented Jul 25, 2023

fadein keyframe had value 0.8 instead of 1 for opacity 100%.

What problem does this PR solve?

Opacity Issue

The Opacity was 0.8 instead of 1

Is this PR adding a new feature?

No

Image 100% opacity

Is this PR related to any issue or discussion?

No

PR Checklist

  • [X ] I have verified that the code works as described/as intended.
  • This change adds a social icon which has a permissive license to use it.
  • [X ] This change does not include any external library/resources.
  • [ X] This change does not include any unrelated scripts (e.g. bash and python scripts).
  • [ X] I have enabled maintainer edits for this PR.

fadein keyframe had value 0.8 instead of 1 for opacity 100%.
@netlify
Copy link

netlify bot commented Jul 25, 2023

Deploy Preview for hugo-blog-awesome ready!

Name Link
🔨 Latest commit f0e9173
🔍 Latest deploy log https://app.netlify.com/sites/hugo-blog-awesome/deploys/64c035a00473e50009dc02bc
😎 Deploy Preview https://deploy-preview-86--hugo-blog-awesome.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@DavidBThomp DavidBThomp marked this pull request as ready for review July 25, 2023 20:51
@sonarcloud
Copy link

sonarcloud bot commented Jul 25, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@hugo-sid
Copy link
Owner

hugo-sid commented Jul 26, 2023

Thanks for fixing the opacity Issue, @DavidBThomp.

I really appreciate your contribution.

@hugo-sid hugo-sid merged commit 79a3101 into hugo-sid:main Jul 26, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants