-
-
Notifications
You must be signed in to change notification settings - Fork 164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: handle relative non-root baseURL #25
Conversation
✅ Deploy Preview for hugo-blog-awesome ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
@kusyka911, this looks pretty exciting. You are correct: this theme is not yet ready for non-root baseURL (or sub-folder baseURL). It is currently ready for root domain or sub-domain based URLs. Looking forward to review this. Thanks for your interest in contributing to this theme. |
@hugo-sid I think there is possibility to make hugo template for |
This pull request has conflicts with the base branch, please resolve those so that we can review the pull request. |
This PR exceeds the recommended size of 200 lines. Kindly ensure that you are NOT addressing multiple issues in one PR. We recommend you to create atomic PRs which focus on a single change. |
Conflicts have been resolved! 🎉 A maintainer will soon review the pull request. |
This PR exceeds the recommended size of 200 lines. Kindly ensure that you are NOT addressing multiple issues in one PR. We recommend you to create atomic PRs which focus on a single change. |
@hugo-sid updated, please review this. I think I covered all possible scenarios. At least for me everything works good. |
Thanks for the hard work @kusyka911.
That's great. If you feel, this PR is ready for review, could you please mark the PR as ready for review? Currently it's a draft PR. |
You may ignore this warning, since you are addressing a single issue in this PR. |
This PR exceeds the recommended size of 200 lines. Kindly ensure that you are NOT addressing multiple issues in one PR. We recommend you to create atomic PRs which focus on a single change. |
Done, also added docs. |
This PR exceeds the recommended size of 200 lines. Kindly ensure that you are NOT addressing multiple issues in one PR. We recommend you to create atomic PRs which focus on a single change. |
This PR exceeds the recommended size of 200 lines. Kindly ensure that you are NOT addressing multiple issues in one PR. We recommend you to create atomic PRs which focus on a single change. |
This PR exceeds the recommended size of 200 lines. Kindly ensure that you are NOT addressing multiple issues in one PR. We recommend you to create atomic PRs which focus on a single change. |
Kudos, SonarCloud Quality Gate passed! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @kusyka911, for this new feature. I think this PR will fix #36.
Thanks for your willingness to improve this theme.
I appreciate your contribution.
What problem does this PR solve?
This PR solve issue with deploying site using relative non-root base URL.
Instruction to reproduce:
with config.toml
or with CLI options
Example nginx configuration
/etc/nginx/nginx.conf
:In this example we have default website in
/usr/share/nginx/html/
and hugo website in/usr/share/nginx/kusyka/
Solution
head.html
place built css file to root of the website and rename to
style.css
use root relative URL for fonts
assets
directory and load them as a resource inhead.html
using.RelPermalink
favicon.ico
placed to site root after build (some browser may request it on root by default)site.webmanifest
andbrowserconfig.xml
to fill them with all needed optionsparams.webmanifest
andparams.browserconfig
Is this PR adding a new feature?
no
Is this PR related to any issue or discussion?
no
PR Checklist