Raise a clear error for QLoRA + vllm_mode="server" instead of a cryptic vLLM crash#6440
Open
DaoyuanLi2816 wants to merge 1 commit into
Open
Conversation
DaoyuanLi2816
force-pushed
the
fix-qlora-vllm-server-mode-guard
branch
from
July 24, 2026 06:53
fc71998 to
e597239
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Want higher recall? High effort reviews run extra passes and find more bugs. A team admin can switch effort levels in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit e597239. Configure here.
DaoyuanLi2816
force-pushed
the
fix-qlora-vllm-server-mode-guard
branch
from
July 24, 2026 07:00
e597239 to
ddf0907
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

What does this PR do?
Rejects QLoRA with
vllm_mode="server"before weight synchronization. Merging a 4-bit PEFT adapter dequantizes its weights, which cannot be loaded by a server expecting packed 4-bit tensors.The same guard is applied to
VLLMGenerationand the self-containedOnlineDPOTrainer. The error directs users to an unquantized server or colocate mode. This is a fail-fast fix for #4973, not full quantized-server support.Tests
AI writing disclosure