Optimize RLOO Trainer memory usage with string-level processing #3837
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR introduces a string-level processing optimization for the RLOO Trainer that reduces GPU memory usage by 55-59% on average. The optimization addresses critical memory inefficiency issues where the current implementation physically duplicates prompt tokens
rloo_k
times in GPU memory, causing OOM errors at higherrloo_k
values.Changes Made
Core optimization: Replace token-level duplication with string-level processing inspired by OnlineDPO:
improvements
Test Results
Experimental validation on RTX 5090 with 3.1K token sequences:
Reproducibility
Complete experimental framework available at: https://github.com/luckyvickyricky/trl-rloo/tree/feat/rloo_string-level-mem-eff
Quick reproduction with 4 scripts:
Fixes #3829
Before submitting
Pull Request section?
to it if that's the case.
Who can review?