Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🛠️ Update tests and fix PPO #2463

Merged
merged 13 commits into from
Dec 12, 2024
Merged

🛠️ Update tests and fix PPO #2463

merged 13 commits into from
Dec 12, 2024

Conversation

kashif
Copy link
Collaborator

@kashif kashif commented Dec 11, 2024

What does this PR do?

Add test for #2453

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@kashif kashif requested a review from qgallouedec December 12, 2024 10:44
@kashif kashif mentioned this pull request Dec 12, 2024
4 tasks
@kashif kashif added the 🐛 bug Something isn't working label Dec 12, 2024
kashif and others added 3 commits December 12, 2024 12:16
Co-authored-by: Quentin Gallouédec <45557362+qgallouedec@users.noreply.github.com>
@qgallouedec
Copy link
Member

Thanks @kashif!

@qgallouedec qgallouedec changed the title [PPOTrainer] add failing test 🛠️ Update tests and fix PPO Dec 12, 2024
@kashif kashif merged commit efc687d into huggingface:main Dec 12, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants