Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔮 Fix unused precomputed ref log probs in DPO #2431

Merged

Conversation

dakru012
Copy link
Contributor

@dakru012 dakru012 commented Dec 3, 2024

What does this PR do?

This PR extends the PreferenceCollator to handle precompute_ref_log_probs.
Additionally, some comments regarding the default data_collator are fixed.

Fixes # #2423

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a GitHub issue? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines.
  • Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

Copy link
Member

@qgallouedec qgallouedec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the fix!
I've tested by hand, it's internally working as expected.

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@qgallouedec qgallouedec changed the title [DPO] Extend PreferenceCollator to handle precomputed ref log probs 🔮 Fix unused precomputed ref log probs in DPO Dec 3, 2024
@qgallouedec qgallouedec merged commit 9ff79a6 into huggingface:main Dec 3, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants