Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add note about special tokens in chat templates for LoRA SFT #2414

Merged
merged 1 commit into from
Nov 29, 2024

Conversation

lewtun
Copy link
Member

@lewtun lewtun commented Nov 29, 2024

What does this PR do?

Sets best practice to avoid the footgun associated with special tokens in chat templates and LoRA SFT: https://x.com/_lewtun/status/1840804557800292843

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a GitHub issue? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines.
  • Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@kashif
Copy link
Collaborator

kashif commented Nov 29, 2024

@lewtun would we need the same warning in the other trainers?

@lewtun lewtun merged commit 2c6e0d9 into main Nov 29, 2024
2 checks passed
@lewtun lewtun deleted the lewtun-patch-1 branch November 29, 2024 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants