Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📑 Refactor TrlParser #2412

Merged
merged 17 commits into from
Dec 2, 2024
Merged

📑 Refactor TrlParser #2412

merged 17 commits into from
Dec 2, 2024

Conversation

qgallouedec
Copy link
Member

@qgallouedec qgallouedec commented Nov 28, 2024

What does this PR do?

First step part of #2380

  • Test TrlParser
  • Deprecate YamlConfigParser (not used outside TrlParser, only get the piece of code and add it to TrlParser)
  • Update TrlParser documentation
  • deprecate post_process_dataclasses (no-op since we removed XXXScriptArgument. We will find another way of passing gradient_checkpointing_use_reentrant
  • Remove config arg from ScriptConfig (not compatible with TrlParser)

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a GitHub issue? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines.
  • Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@qgallouedec qgallouedec marked this pull request as ready for review November 29, 2024 09:51
@qgallouedec qgallouedec requested review from lewtun and kashif November 29, 2024 09:51
@qgallouedec qgallouedec changed the title Refactor TrlParser 📑 Refactor TrlParser Nov 29, 2024
Copy link
Member

@lewtun lewtun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice harmonisation with the parser @qgallouedec ! LGTM with an ask to include 1 more test

trl/commands/cli_utils.py Outdated Show resolved Hide resolved
trl/commands/cli_utils.py Show resolved Hide resolved
tests/test_cli_utils.py Show resolved Hide resolved
@qgallouedec qgallouedec merged commit 9001a86 into main Dec 2, 2024
12 of 14 checks passed
@qgallouedec qgallouedec deleted the trl-parser-refactor branch December 2, 2024 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants