Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔓 Remove lm_head check in AutoModelForCausalLMWithValueHead #2398

Merged
merged 3 commits into from
Nov 29, 2024

Conversation

qgallouedec
Copy link
Member

What does this PR do?

I don't know why we have this error. Removing it doesn't induce any subsequent error.

Fixes #2362

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a GitHub issue? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines.
  • Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@qgallouedec qgallouedec requested review from kashif and lewtun November 26, 2024 15:11
@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Copy link
Member

@lewtun lewtun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed, perhaps this is an artifact from the pre-LLM days in transformers. LGTM

@qgallouedec qgallouedec merged commit 94e4135 into main Nov 29, 2024
14 checks passed
@qgallouedec qgallouedec deleted the release-lm-head-for-automodelwithvaluehead branch November 29, 2024 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Still not supporting for ChatGLM3 maybe
3 participants