Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🧳 Move zen generation script and fix tests #2393

Merged
merged 8 commits into from
Nov 26, 2024
Merged

🧳 Move zen generation script and fix tests #2393

merged 8 commits into from
Nov 26, 2024

Conversation

qgallouedec
Copy link
Member

@qgallouedec qgallouedec commented Nov 25, 2024

What does this PR do?

It makes more sense to have it in scripts since the dataset is only used for testing purposes.

I realised that each time you run the generation script for zen, it shuffles the dataset, resulting in some tests to fail.
This PR fixes it.

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a GitHub issue? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines.
  • Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@qgallouedec qgallouedec requested review from kashif and lewtun November 25, 2024 15:41
@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@qgallouedec qgallouedec changed the title 🧳 Move zen generation script 🧳 Move zen generation script and fix tests Nov 25, 2024
tests/test_sft_trainer.py Outdated Show resolved Hide resolved
@qgallouedec qgallouedec merged commit 43df3a4 into main Nov 26, 2024
14 checks passed
@qgallouedec qgallouedec deleted the move-zen branch November 26, 2024 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants