Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🤐 Fix deprecation warnings #2392

Merged
merged 2 commits into from
Nov 26, 2024
Merged

Conversation

qgallouedec
Copy link
Member

What does this PR do?

I realized that the deprecation warnings were not displayed because the deprecate_kwarg function compares the version passed as an argument (for us it's the TRL version) with the version of transformers. And if this version is higher, then the message is not displayed.

We could implement our own version of this decorator to use the TRL version (and not the transformers version), but the easiest way is to hack the function with the argument warn_if_greater_or_equal_version.

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a GitHub issue? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines.
  • Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@qgallouedec qgallouedec requested review from kashif and lewtun November 25, 2024 14:24
@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@qgallouedec qgallouedec merged commit 4f937c7 into main Nov 26, 2024
14 checks passed
@qgallouedec qgallouedec deleted the fix-deprecation-warning-message branch November 26, 2024 10:18
@qgallouedec qgallouedec mentioned this pull request Nov 26, 2024
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants