generated from fastai/nbdev_template
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
📉 Add PEFT support for PPOTrainer
#2344
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ccs96307
changed the title
[Draft] Add PEFT Support for PPOTrainer
Add PEFT Support for PPOTrainer
Nov 11, 2024
very nice @ccs96307! looking into details |
qgallouedec
changed the title
Add PEFT Support for PPOTrainer
📉 Add PEFT support for Nov 11, 2024
PPOTrainer
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
ccs96307
force-pushed
the
feature-ppo-peft
branch
from
November 12, 2024 04:21
f8385d1
to
dde20b2
Compare
qgallouedec
reviewed
Nov 14, 2024
Co-authored-by: Quentin Gallouédec <45557362+qgallouedec@users.noreply.github.com>
qgallouedec
approved these changes
Nov 18, 2024
Thanks a lot @ccs96307 for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR provides an initial implementation of PEFT support for PPOTrainer, targeted towards the policy model. The existing functionality remains fully intact and unaffected by these modifications.
The following tasks have been completed:
peft_config
forPPOTrainer
tests/test_ppo_trainer.py
(next: implement unit tests to cover the newpeft_config
integration)examples/scripts/ppo/ppo_tldr.py
examples/scripts/ppo/ppo.py
As of now, this implementation does not support quantization or gradient checkpointing.
If there’s anything inappropriate or suboptimal in my implementation, please feel free to let me know—I’m open to all feedback and eager to improve to align with the project standards.
Fixes #1916
Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.