Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🔀 Add
MergeModelCallBack
#2282🔀 Add
MergeModelCallBack
#2282Changes from 7 commits
63f7ae0
55f3a25
9f829fa
f666369
bb52d4b
5d9a5a9
9ba148c
0fe2d67
caee4b2
b278e5a
311a27a
ec8b5ec
147b188
7f5dbc1
c17f8e3
0d9c8a0
ca07b42
6229885
9ea5a6b
1a2b425
f0f84eb
c924cb9
8b5a4a9
34e94ff
0a5db60
906eafa
8d03608
eb66e99
eb7b228
1057c59
1c85ee5
18d0388
ca8f361
0a25ee8
cd76890
c8afdbc
26aa418
fb12119
88de59a
fed6045
01e38c8
9e7a068
fa5bafe
47ecef5
7fe26d5
a57d88a
69ea0ed
d89eadc
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please add a docstring like we do for our model training configs:
trl/trl/trainer/dpo_config.py
Line 34 in 6239631
This way it renders nicely in the docs :)
It would be good to provide some links to the various supported methods
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Useful ressource: #1944 (comment)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I got GPT to add the docstring.
is it ok?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure!