Add Sequence-Level KD #2220
Merged
Add Sequence-Level KD #2220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add the third issue fixs
|
thanks @mst272 can you also kindly add these options to the docs-strings and the documentation of |
# Conflicts: # examples/scripts/dpo.py # trl/commands/cli_utils.py
|
hi@kashif,I've added these to the docs-strings and the documentation |
kashif
reviewed
Oct 11, 2024
kashif
reviewed
Oct 11, 2024
kashif
reviewed
Oct 11, 2024
qgallouedec
reviewed
Oct 11, 2024
qgallouedec
approved these changes
Oct 11, 2024
Co-authored-by: Quentin Gallouédec <45557362+qgallouedec@users.noreply.github.com>
kashif
approved these changes
Oct 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
In the original paper, they compared Sequence-Level KD 、Supervised KD and GKD (On-policy). In trl GKDTrainer, Supervised KD and GKD have been implemented. So i add Sequence-Level KD in GKDTrainer, control whether to perform Sequence-Level KD through a seq_kd parameter.
Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.