Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix deepspeed for PPOv2Trainer #2080

Merged
merged 1 commit into from
Sep 19, 2024
Merged

Fix deepspeed for PPOv2Trainer #2080

merged 1 commit into from
Sep 19, 2024

Conversation

qgallouedec
Copy link
Member

@qgallouedec qgallouedec commented Sep 19, 2024

What does this PR do?

Fixes #2025

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a GitHub issue? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines.
  • Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@qgallouedec qgallouedec linked an issue Sep 19, 2024 that may be closed by this pull request
4 tasks
@qgallouedec
Copy link
Member Author

@danaaubakirova can you check it solves the issue?
cc @RylanSchaeffer

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@danaaubakirova
Copy link

@qgallouedec yes, It works for me! Thanks a lot!

Copy link
Member

@lewtun lewtun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix! I wasn't aware the self.deepspeed was needed, but I guess this reflects the fact we are relying heavily on the Trainer internals.

@qgallouedec qgallouedec merged commit cc80ac6 into main Sep 19, 2024
10 checks passed
@qgallouedec qgallouedec deleted the fix-2025 branch September 19, 2024 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AttributeError: 'PPOv2Trainer' object has no attribute 'deepspeed'
5 participants