Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused functions in core.py #2017

Merged
merged 3 commits into from
Sep 8, 2024

Conversation

northern-64bit
Copy link
Contributor

What does this PR do?

It removes unused functions in core.py. I could not find any usage of them and these are probably old remnants of previous code, but if these are support functions and are used, just let me know and I'll close the PR.

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

Copy link
Member

@lewtun lewtun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the clean up @northern-64bit ! LGTM

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@qgallouedec qgallouedec merged commit 8a518ee into huggingface:main Sep 8, 2024
9 checks passed
@northern-64bit northern-64bit deleted the remove_unused_core branch September 8, 2024 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants