Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Standardize dataset_num_proc usage #1925

Merged
merged 6 commits into from
Aug 13, 2024
Merged

Standardize dataset_num_proc usage #1925

merged 6 commits into from
Aug 13, 2024

Conversation

qgallouedec
Copy link
Member

No description provided.

@HuggingFaceDocBuilderDev
Copy link

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@qgallouedec qgallouedec marked this pull request as ready for review August 13, 2024 12:11
lewtun
lewtun approved these changes Aug 13, 2024
View reviewed changes
Copy link
Member

@lewtun lewtun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the QoL improvement! Left a few nits, but otherwise LGTM

examples/datasets/anthropic_hh.py Outdated Show resolved Hide resolved
examples/scripts/ppo.py Outdated Show resolved Hide resolved
examples/scripts/ppo.py Outdated Show resolved Hide resolved
qgallouedec and others added 3 commits August 13, 2024 15:07
@qgallouedec @lewtun
Update examples/datasets/anthropic_hh.py
03bdb14 
Co-authored-by: lewtun <lewis.c.tunstall@gmail.com>
@qgallouedec @lewtun
Update examples/scripts/ppo.py
06b38fd 
Co-authored-by: lewtun <lewis.c.tunstall@gmail.com>
@qgallouedec @lewtun
Update examples/scripts/ppo.py
792af0b 
Co-authored-by: lewtun <lewis.c.tunstall@gmail.com>
@qgallouedec
Copy link
Member Author

Thanks for the comments @lewtun!

@qgallouedec qgallouedec merged commit 54f806b into main Aug 13, 2024
3 of 5 checks passed
@qgallouedec qgallouedec deleted the uniform_dataset_num_proc branch August 13, 2024 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lewtun lewtun lewtun approved these changes

@kashif kashif Awaiting requested review from kashif

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@qgallouedec @HuggingFaceDocBuilderDev @lewtun