Skip to content

whiten_rewards parameter in RLOO config is not used. #2665

@velezbeltran

Description

@velezbeltran

Reproduction

Hello!

I think there is a small bug. I was trying to find out what the difference was between the whiten_rewards and normalize_rewards parameter in the RLOOConfig object and after inspecting the code for the RLOOTrainer class I found that it is not used. Hence, I think it should probably be removed.

Image

Thank you for your help and the codebase! It is super helpful.

System Info

I can see this in the codebase.

Checklist

  • I have checked that my issue isn't already filed (see open issues)
  • I have included my system information
  • Any code provided is minimal, complete, and reproducible (more on MREs)
  • Any code provided is properly formatted in code blocks, (no screenshot, more on code blocks)
  • Any traceback provided is complete

Metadata

Metadata

Assignees

No one assigned

    Labels

    🏋 RLOORelated to RLOO🐛 bugSomething isn't working

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions