add some tests back

huggingface · Dec 5, 2024 · 350aef5 · 350aef5
1 parent 985e3e6
commit 350aef5
Show file tree

Hide file tree

Showing 3 changed files with 0 additions and 21 deletions.
diff --git a/tests/test_cli.py b/tests/test_cli.py
@@ -12,12 +12,10 @@
 # See the License for the specific language governing permissions and
 # limitations under the License.
 import subprocess
-import sys
 import unittest
 
 
 class CLITester(unittest.TestCase):
-    @unittest.skipIf(sys.platform.startswith("win"), "Skipping on Windows")
     def test_sft_cli(self):
         try:
             subprocess.run(
@@ -28,7 +26,6 @@ def test_sft_cli(self):
         except BaseException:
             self.fail("An error occurred while running the CLI, please double check")
 
-    @unittest.skipIf(sys.platform.startswith("win"), "Skipping on Windows")
     def test_dpo_cli(self):
         try:
             subprocess.run(

diff --git a/tests/test_ppo_trainer.py b/tests/test_ppo_trainer.py
@@ -11,7 +11,6 @@
 # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 # See the License for the specific language governing permissions and
 # limitations under the License.
-import platform
 import subprocess
 
 from transformers.testing_utils import require_peft
@@ -34,10 +33,6 @@ def test():
     --save_strategy no \
     --stop_token eos
 """
-    if platform.system() == "Windows":
-        # windows CI does not work with subprocesses for some reason
-        # e.g., https://github.com/huggingface/trl/actions/runs/9600036224/job/26475286210?pr=1743
-        return
     subprocess.run(
         command,
         shell=True,
@@ -62,10 +57,6 @@ def test_num_train_epochs():
     --save_strategy no \
     --stop_token eos
 """
-    if platform.system() == "Windows":
-        # windows CI does not work with subprocesses for some reason
-        # e.g., https://github.com/huggingface/trl/actions/runs/9600036224/job/26475286210?pr=1743
-        return
     subprocess.run(
         command,
         shell=True,
@@ -93,10 +84,6 @@ def test_peft_support():
     --lora_alpha 16 \
     --lora_target_modules query_key_value dense
 """
-    if platform.system() == "Windows":
-        # windows CI does not work with subprocesses for some reason
-        # e.g., https://github.com/huggingface/trl/actions/runs/9600036224/job/26475286210?pr=1743
-        return
     subprocess.run(
         command,
         shell=True,

diff --git a/tests/test_rloo_trainer.py b/tests/test_rloo_trainer.py
@@ -11,7 +11,6 @@
 # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 # See the License for the specific language governing permissions and
 # limitations under the License.
-import platform
 import subprocess
 import tempfile
 import unittest
@@ -40,10 +39,6 @@ def test():
     --save_strategy no \
     --stop_token eos
 """
-    if platform.system() == "Windows":
-        # windows CI does not work with subprocesses for some reason
-        # e.g., https://github.com/huggingface/trl/actions/runs/9600036224/job/26475286210?pr=1743
-        return
     subprocess.run(
         command,
         shell=True,