Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update 'Develop on Windows' guidelines #9519

Merged
merged 1 commit into from
Jan 12, 2021
Merged

Update 'Develop on Windows' guidelines #9519

merged 1 commit into from
Jan 12, 2021

Conversation

SBrandeis
Copy link
Contributor

What does this PR do?

Update the Develop on Windows guidelines in CONTRIBUTING.md to add:

  • Instructions to setup git to handle CRLF line endings
  • Instructions to add MSYS executables in your PATH to run make from another terminal

Fixes #9438

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).

Who can review?

@sgugger
@jplu

@SBrandeis SBrandeis requested a review from sgugger January 11, 2021 15:59
@sgugger
Copy link
Collaborator

sgugger commented Jan 11, 2021

Do you have any idea why GitHub is not showing the diff properly?

@SBrandeis
Copy link
Contributor Author

SBrandeis commented Jan 11, 2021 •
edited
Loading

Looks like I'm having an issue with CRLFs :( I think I replaced all CRLFs by LFs
I'm currently investigating this

@SBrandeis SBrandeis changed the title Update 'Develop on Windows' guidelines [WIP] Update 'Develop on Windows' guidelines Jan 11, 2021
@SBrandeis SBrandeis force-pushed the contributing_windows_update branch from 51afb83 to 0bc17ca Compare January 11, 2021 16:10
@SBrandeis SBrandeis changed the title [WIP] Update 'Develop on Windows' guidelines Update 'Develop on Windows' guidelines Jan 11, 2021
@SBrandeis
Copy link
Contributor Author

@sgugger problem solved 👌

sgugger
sgugger approved these changes Jan 11, 2021
View reviewed changes
Copy link
Collaborator

@sgugger sgugger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much better, thanks for adding this!

LysandreJik
LysandreJik approved these changes Jan 12, 2021
View reviewed changes
Copy link
Member

@LysandreJik LysandreJik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@LysandreJik LysandreJik merged commit 3b67c5a into huggingface:master Jan 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sgugger sgugger sgugger approved these changes

@LysandreJik LysandreJik LysandreJik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Doc styling utils adds parasites new lines
3 participants
@SBrandeis @sgugger @LysandreJik