-
Notifications
You must be signed in to change notification settings - Fork 27.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feed forward chunking #6024
Merged
LysandreJik
merged 14 commits into
huggingface:master
from
Pradhy729:feed_forward_chunking
Aug 11, 2020
Merged
Feed forward chunking #6024
Changes from 1 commit
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
62788a7
Merge pull request #1 from huggingface/master
Pradhy729 b413437
Merge pull request #2 from huggingface/master
Pradhy729 fcaa3aa
Merge pull request #3 from huggingface/master
Pradhy729 623352f
Merge pull request #4 from huggingface/master
Pradhy729 5a26a2d
Merge pull request #5 from huggingface/master
Pradhy729 c96bc33
Merge pull request #6 from huggingface/master
Pradhy729 b85adeb
Merge pull request #7 from huggingface/master
Pradhy729 c0fdd09
Chunked feed forward for Bert
Pradhy729 d2d531c
Black and cleanup
Pradhy729 f0e3826
Feed forward chunking in BertLayer class.
Pradhy729 5655ddf
Isort
Pradhy729 9f07b10
add chunking for all models
patrickvonplaten 37a0963
fix docs
patrickvonplaten 406d621
Fix typo
patrickvonplaten File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Feed forward chunking in BertLayer class.
- Loading branch information
commit f0e3826eef61c1f1705eec046918fb1c3424df95
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very much a nitpick here, for future PRs probably, but this looks a lot like the gradient checkpointing method from PyTorch. This method takes the callable (the forward) method as first positional argument and I think it makes sense to have it this way.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can do this globally in the new PR where I add the chunking for other models. Let me know if you have concerns with that.