[examples] fixes arguments for summarization finetune scripts #5157
Conversation
ieBoytsov
changed the title
ieBoytsov
changed the title
Codecov Report
@@ Coverage Diff @@
## master #5157 +/- ##
=======================================
Coverage 77.93% 77.94%
=======================================
Files 137 137
Lines 23475 23475
=======================================
+ Hits 18295 18297 +2
+ Misses 5180 5178 -2
Continue to review full report at Codecov.
|
examples/summarization/finetune.sh
Outdated
| @@ -11,6 +11,8 @@ export PYTHONPATH="../":"${PYTHONPATH}" | |||
|
|
|||
| python finetune.py \ | |||
| --model_name_or_path=facebook/bart-large \ | |||
| --data_dir=./cnn-dailymail/cnn_dm \ | |||
There was a problem hiding this comment.
Can we leave this in the README and add a comment in this file that the proper usage is documented in the README. I would rather not hardcode paths to data in this script, since people are using many different datasets stored in different places.
There was a problem hiding this comment.
Sure, please check my 2nd commit, i also dropped cnn prefix from default output dir in finetune.sh. Maybe it makes sense not to hardcode it as well? Will be glad to hear your feedback.
ieBoytsov
force-pushed
the
finetune-arguments-fixes-for-summarization
branch
from
590e32b to
7f0c46d
Compare
This PR fixes arguments in bash scripts for finetuning bart/bart_tiny/t5 models in summarization examples.
After changes that were merged in #4951 i noticed some small problems. That includes:
finetune.py(--data_dir, output_dir)n_gpuinstead ofgpus)model_typethat is not present in list of arguments and crashes the script