Python code in model docs - #45608
Conversation
|
One quick one: missing device map auto on models and or missing movement from prepared input |
|
This will need an agent help, not super regex friedly. Oke, noted |
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
19f0410 to
01c0319
Compare
|
@stevhliu this PR is generated by find-replace and code agent. As per title, eliminates most common patterns in new model reviews, so users don't copy a bad example Whenever you have time, can you reveiew? |
|
@zucchini-nlp Another one maybe for a different PR: Using httpx vs requests. Sorry dropping stuff as I review other models atm :D |
|
No prob, gotta keep docs clean and anyway it is the LLM doing the work, I just re-check. Defi another PR opportunity :) |
stevhliu
left a comment
There was a problem hiding this comment.
nice, thanks for the clean up! 🧹 some issues i've noticed so far:
- using the wrong bnb arg (
bnb_4bit_compute_bnb_4bit_quant_typevsbnb_4bit_quant_dtype) - double commas after the
model - indenting off for some
device_mapargs - some examples use
device=0while othersdevice=0is removed
|
Love vibe-coding, always have to check and clean manually afterwards 😄 I'll go over and fix those |
|
I think it is better now, applied ruff to fix indentation, reverted all |
stevhliu
left a comment
There was a problem hiding this comment.
just a few more things, but otherwise lgtm! i'll add these conventions to my model doc skill so all future model docs follow these :)
Co-authored-by: Steven Liu <59462357+stevhliu@users.noreply.github.com>
|
Yep, thanks, imo with the skill and a bit more requirements on using the provided doc-template, we can cut down time spent reviewing new model docs |
What does this PR do?
torch_dtypeanddtype, since we load models in default dtype from config in v5>>>and...)Batch updating because I see many comments in new model PRs asking users to fix it, though the best way is for us to fix old docs
@vasqu , do you have any other recurring/annoying patterns? Would be great to reduce number of nitty-picky PR comments, and save us time for more important tasks