Skip to content

Update min_lr and max_lr default values to better defaults #45168

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
w601sxs wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Update min_lr and max_lr default values to better defaults #45168

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/transformers/optimization.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -649,9 +649,9 @@ class GreedyLR:
Number of epochs to wait before resuming normal operation after LR has been reduced.
warmup (`int`, *optional*, defaults to 0):
Number of epochs to wait before resuming normal operation after LR has been increased.
min_lr (`float` or `list[float]`, *optional*, defaults to 0.001):
min_lr (`float` or `list[float]`, *optional*, defaults to 1e-7):
A lower bound on the learning rate.
max_lr (`float` or `list[float]`, *optional*, defaults to 1.0):
max_lr (`float` or `list[float]`, *optional*, defaults to 1e-4):
An upper bound on the learning rate.
eps (`float`, *optional*, defaults to 1e-08):
Minimal decay applied to lr.
Expand Down Expand Up @@ -685,8 +685,8 @@ def __init__(
threshold_mode: str = "abs",
cooldown: int = 0,
warmup: int = 0,
min_lr: float | list[float] = 1e-3,
max_lr: float | list[float] = 1.0,
min_lr: float | list[float] = 1e-7,
max_lr: float | list[float] = 1e-4,
eps: float = 1e-8,
verbose: bool = False,
smooth: bool = False,
Expand Down
Loading