Conversation
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
Contributor
Author
|
run-slow: lightglue |
Contributor
|
[For maintainers] Suggested jobs to run (before merge) run-slow: lightglue |
Contributor
|
This comment contains models: ["models/lightglue"] |
vasqu
added
the
for patch
tarekziade
approved these changes
Mar 31, 2026
Collaborator
tarekziade
left a comment
tarekziade
left a comment
There was a problem hiding this comment.
For the linter part LGTM. I think dynamic kwargs can evade the static checker but it cannot be fully solved but that's fine imho
sirzechs66
pushed a commit
to sirzechs66/transformers
that referenced
this pull request
Mar 31, 2026
SangbumChoi
pushed a commit
to SangbumChoi/transformers
that referenced
this pull request
Apr 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Native model integration should never have anything related to remote code execution: That just means that we would need to add that model natively, not via remote - it can and will not be maintained by us.
Additionally added a new linter rule to check for simple usage of this via
trust_remote_code=...NOTE: The breaking part that we effectively deprecate a subset of the lightglue models (which should not have been added this way); see lightglue_disk and this hub PR