[Tests] Fix slow video tensor creation from list of numpy arrays in SmolVLM#44731
Merged
zucchini-nlp merged 2 commits intoJul 16, 2026
Merged
Conversation
This was referenced Apr 29, 2026
Contributor
CI recapDashboard: View test results in Grafana |
zucchini-nlp
approved these changes
Jul 16, 2026
zucchini-nlp
left a comment
Member
There was a problem hiding this comment.
With the test setting and 8 frames, not much win at the end. But yeah, why not, let's merge it an make our tests slightly faster :)
zucchini-nlp
enabled auto-merge
July 16, 2026 12:24
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
While running SmolVLM tests I noticed this warning in the output:
Tracked it down to
prepare_video()intests/test_video_processing_common.py— it builds a list of numpy arrays (one per frame), then passes that list straight totorch.tensor(). PyTorch really doesn't like this; it ends up iterating over each array one by one instead of doing a bulk conversion.The fix is simple — consolidate into a single numpy array first, then hand it to torch:
np.array()was already imported. Output is bit-identical (verified withtorch.equal()), warning is gone.Quick benchmark on Apple M-series, 500 iterations:
All SmolVLM tests pass (302 passed, 186 skipped, 0 failures). No other instances of this pattern in
tests/*.py.Fixes # (issue)
Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
@yonigozlan @zucchini-nlp