Migrate GPT2 to standardized output capture decorators - #43983
Merged
ArthurZucker merged 6 commits intoFeb 18, 2026
Conversation
Aki-07
force-pushed
the
ak/gpt2-standardized-outputs
branch
from
February 13, 2026 18:30
fbc8efc to
1458ec2
Compare
Aki-07
force-pushed
the
ak/gpt2-standardized-outputs
branch
from
February 14, 2026 09:47
cc0357c to
96588f6
Compare
Member
|
cc @molbap |
Comment on lines
+400
to
+401
| kwargs.pop("output_attentions", None) | ||
| kwargs.pop("output_hidden_states", None) |
Collaborator
There was a problem hiding this comment.
this should not be needed
Contributor
Author
There was a problem hiding this comment.
Removed these two kwargs. Thanks for catching this
| output_attentions: bool | None = None, | ||
| output_hidden_states: bool | None = None, | ||
| return_dict: bool | None = None, | ||
| **kwargs, |
Collaborator
There was a problem hiding this comment.
would be nice to type them
Contributor
|
[For maintainers] Suggested jobs to run (before merge) run-slow: decision_transformer, gpt2 |
Aki-07
force-pushed
the
ak/gpt2-standardized-outputs
branch
from
February 17, 2026 18:53
1f40dbf to
0403db9
Compare
ArthurZucker
enabled auto-merge (squash)
February 18, 2026 10:33
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #43979
Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
@ArthurZucker @Cyrilvallez
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.