Skip to content

Fix QA max_answer_len validation error message #42949

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
antznette1 wants to merge 1 commit into
base: main
Choose a base branch
from
+7 −1
Open

Fix QA max_answer_len validation error message #42949

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/transformers/pipelines/question_answering.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -328,7 +328,7 @@ def _sanitize_parameters(
postprocess_params["top_k"] = top_k
if max_answer_len is not None:
if max_answer_len < 1:
raise ValueError(f"max_answer_len parameter should be >= 1 (got {max_answer_len}")
raise ValueError(f"max_answer_len parameter should be >= 1 (got {max_answer_len})")
postprocess_params["max_answer_len"] = max_answer_len
if handle_impossible_answer is not None:
postprocess_params["handle_impossible_answer"] = handle_impossible_answer
Expand Down
6 changes: 6 additions & 0 deletions tests/pipelines/test_pipelines_question_answering.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -546,3 +546,9 @@ def test_argument_handler_error_handling_odd(self):

with self.assertRaises(ValueError):
qa(1)

class QuestionAnsweringPipelineSanitizeParametersTests(unittest.TestCase):
def test_sanitize_parameters_max_answer_len_error_message(self):
qa = object.__new__(QuestionAnsweringPipeline)
with self.assertRaisesRegex(ValueError, r"max_answer_len parameter should be >= 1 \(got 0\)"):
qa._sanitize_parameters(max_answer_len=0)